-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Citadel] Add all features to tpeplugin #46
Conversation
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
I cleaned up the code a bit more. Ready for another round of review 🙇♀️ |
Signed-off-by: Ian Chen <[email protected]>
I made some very minor changes in f952393. I think the PR is good to go. Approve once the homebrew issue is fixed. |
I think the homebrew issue was due to a Java bug on |
@chapulina mind taking another look since there are requested changes from you blocking merge? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with the tests! I have some more comments below. Most are nitpicks, but I think it would be good to address others before merging.
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
Signed-off-by: claireyywang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it!
This PR add all the features to
tpeplugin
and enables testing with example worlds. This PR should be merged after #45 (adds needed functions totpelib
) and #32 (implementsBase
andEntityManagementFeatures
).A few things need to be addressed by follow-up PRs
VelocityCmd
toign-gazebo/src/systems/physics/Physics.cc
to enable setting world velocity without applying force to jointSo far, any models without joint should be able to transform pose with TPE.
To test with ignition gazebo
Terminal output
The shapes no longer collapse to origin after the commit 344f7f4 , and warnings are fixed by commit 01bf3de
Shapes can be moved around by using transform tools after commit ad391b3
Demo
I also tried with a couple other example worlds. See performance summary below:
actor.sdf
: loads fine, actors move, warns missing joint entity, can't transform poseapply_joint_force.sdf
: loads fine, warns missing joint entity, can't transform posebreadcrumbs.sdf
: loads fine, warns missing joint, can't transform posecamera_sensor.sdf
: loads fine, sensor works, cube transforms pose, cone doesn’t and warns missing joint entitycontact_sensor
: loads fine, transforms pose, sensor worksfuel.sdf
: loads fine, warns missing joint entity, actor can move, can't transform posetunnel.sdf
: loads fine, warns missing joint entity, car transforms pose