Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport ogre2 depth camera fix #138

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 9, 2020

backport changes from pull request #130 to fix #129

ign-rendering2 does not run ogre2 test on jenkins so there shouldn't be a change in the CI build results. However, ign-sensors2 and ign-gazebo2 both run rendering tests with ogre2, so this change should fix their depth and rgb camera test failures on ubuntu CI builds

@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Sep 9, 2020
@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #138 into ign-rendering2 will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering2     #138      +/-   ##
==================================================
+ Coverage           51.39%   51.42%   +0.03%     
==================================================
  Files                 117      117              
  Lines               10071    10078       +7     
==================================================
+ Hits                 5176     5183       +7     
  Misses               4895     4895              
Impacted Files Coverage Δ
ogre2/src/Ogre2DepthCamera.cc 93.93% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f0235a...d73d80a. Read the comment docs.

chapulina added a commit to gazebo-tooling/release-tools that referenced this pull request Sep 15, 2020
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor

Triggered ign-sensors2 CI using this branch:

Build Status

It uses this release-tools branch:

https://github.com/ignition-tooling/release-tools/compare/chapulina/rendering/pr/138

@chapulina
Copy link
Contributor

@osrf-jenkins run tests one more time

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with happy CI

@iche033 iche033 merged commit 8f049ce into ign-rendering2 Sep 28, 2020
@iche033 iche033 deleted the port_depth_ogre2_fix branch September 28, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants