Fix some ILM Timezone Madness #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just use the date. Not the time.
ILM Sessions are coming from the API with a UTC time, but that isn’t really true. They have no real timestamp. This forces them to appear at 5pm on the correct date.
|
@saschaben this can be tested against demo. |
This correctly captures ILMs at the edge of a time period. Like the beginning of a week or any day view.
|
👍 |
|
👍 |
|
LGTM 👍 |
stopfstedt
added a commit
that referenced
this pull request
Dec 21, 2015
Fix some ILM Timezone Madness
stopfstedt
pushed a commit
to stopfstedt/frontend
that referenced
this pull request
Mar 6, 2024
Update Transitive Dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ILM Sessions are coming from the API with a UTC time, but that isn’t
really true. They have no real timestamp. This forces them to be saved and to appear at 5pm on the correct date.