display owner rather than author in learning material detail list #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gboushey The failing test is due to a very similar set of tests in tests/acceptance/course/learningmaterials-test.js They look the same, but one tests learning materials attached to a session and the other tests them attached to a course. |
…session, to reflect change from author to owner in the learning material table
saschaben
added a commit
that referenced
this pull request
Jan 14, 2016
display owner rather than author in learning material detail list
stopfstedt
pushed a commit
to stopfstedt/frontend
that referenced
this pull request
Mar 6, 2024
…use-db-1.0.30001494 Bump caniuse-db from 1.0.30001492 to 1.0.30001494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1258.
Changed the value from lmProxy.learningMaterial.originalAuthor to lmProxy.learningMaterial.owningUser.fullName.
Added user fields to fixtures to test in tests/acceptance/course/session/learningmaterials-test.js and updated acceptance tests.
note - I think this issue may also be present in print-course.hbs