Improved handling of competency domains #1945
Conversation
|
@saschaben please test. |
|
jrjohnson
changed the title
|
blocked by #1947. Waiting for merge to test and validate. |
|
Looking good functionally. only issue I see is with the handlling of the objective parent selector: if you click on any domain, the highlighting and checkbox are activated as expected -- but if you click directly on the checkbox, it activates the highlighting, but not the checkbox itself. This is a visual UX issue only -- functionally the select works regardless. |
|
Issues with checkboxes fixed, assigning to @stopfstedt for code review |
|
We eventually will have to deal with the "challenged" refreshing of available competencies for selection when both managers are open and there is no intervening page refresh, but that is for another day. |
|
@saschaben I wasn't able to get that to happen again, thought maybe it was my imagination. Are you seeing it here? |
|
@jrjohnson it only occurs with objectives that are already hooked up to a parent; if you modify the competency set while the objective manager is also open and then try to change a parent to a newly added competency, this pops up. It's not a common use pattern and should not block this pr. |
|
☔ The latest upstream changes (presumably #1947) made this pull request unmergeable. Please resolve the merge conflicts. |
Remove the tree concept and get rid of the management component in favor of doing the management in programyear-competencies component directly.
Previously only competencies within a domain not a top level competency could be added to a program year objective. This was insufficient as some program years use only top level competencies.
Mistakenly looking at the school set instead of the program year set.
Using a single checked attribute for this didn't work because clicking on it changed the state. Instead we have to create a new box for each case so it stays checked when clicked.
jrjohnson
force-pushed
the
1696-singlecompetency
branch
from
8a62381 to
16617ad
Compare
|
LGTM |
This set of changes allows a program year to be associated with top level competencies (domains). They can also be associated with program year objectives.
Fixes #1696