Remove ui-select and use a standard select element #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
1946-remove-uiselect
branch
from
4a5f9ac to
5e1f143
Compare
jrjohnson
changed the title
jrjohnson
force-pushed
the
1946-remove-uiselect
branch
from
5e1f143 to
ef1da4c
Compare
|
functionality-wise this looks good to me. however, some of the styles are off.
|
|
I would have bet anything that we had center placed add buttons on other lists. I would have been 100% wrong I guess. I can't find a single one. Maybe they're just like that in my head.... will fix. Good catch. |
|
@stopfstedt I fixed the alignment of the expand button, however the saved section matches the one in courses and instructor groups so I left it as is to deal with later. |
|
clicktests are AOK. when tests pass this looks good to merge. I will add a separate ticket regarding the save message alignment. |
|
Tests are filing in some crazy random fashion. Really annoying, investigating..... |
The ui-select component is gone we were only using it to pick the start date for a program year which can be done with a select list just as well.
This moves the expand button into the correct place and also matches the other lists.
jrjohnson
force-pushed
the
1946-remove-uiselect
branch
2 times, most recently
from
b7bb95d to
429d9d2
Compare
For some reason the first integration test seems to fail to find elements correctly. Probably an artifact of the acceptance tests is confusing jquery. Adding a first test which does not rely on the DOM seems to fix this until we find a better permanent solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ui-select component is gone we were only using it to pick the start
date for a program year which can be done with a select list just as
well.
Fixes #1946