Update Ember to 5.2 #7375
Merged
Update Ember to 5.2 #7375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The names of some tests shifted, so the missing tests aren't really missing. Ready for review. |
dartajax
approved these changes
Aug 30, 2023
stopfstedt
force-pushed
the
update-ember-5.1
branch
from
e8718a6 to
e1f8284
Compare
stopfstedt
approved these changes
Aug 31, 2023
Closed
With ember-cli-update and all blueprints.
ember-page-title v8 removed the pageTitleList service so we don't need to include it anymore here.
New auto formatting from prettier.
Setting this to except-simple matches our current code and format, so is the smallest changeset here now that the qunit/recommended rule has changed. See: https://github.com/platinumazure/eslint-plugin-qunit/blob/master/docs/rules/require-expect.md for information on this setting
stopfstedt
force-pushed
the
update-ember-5.1
branch
from
c288e1a to
7bb5543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 5.x series of ember is stable and we've cleared our deprecation and fixed everything upstream that needed fixing. I think we're good to go here, will see what tests and some manual clicking say.