Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember 5.2 #7380

Closed
wants to merge 6 commits into from
Closed

Conversation

stopfstedt
Copy link
Member

@stopfstedt stopfstedt commented Aug 31, 2023

duplicate of #7375, which seems to be stuck in GH action limbo.

jrjohnson and others added 6 commits August 31, 2023 12:43
With ember-cli-update and all blueprints.
ember-page-title v8 removed the pageTitleList service so we don't need
to include it anymore here.
New auto formatting from prettier.
Setting this to except-simple matches our current code and format, so is
the smallest changeset here now that the qunit/recommended rule has
changed. See:
https://github.com/platinumazure/eslint-plugin-qunit/blob/master/docs/rules/require-expect.md
for information on this setting
this PR seems to be stuck in CI after the rebase against master,
rebuilding the lock file tends to knock things lose in GH actions, so
let's try that.
@stopfstedt
Copy link
Member Author

nevermind, this one's stuck as well.

@stopfstedt stopfstedt closed this Aug 31, 2023
@stopfstedt stopfstedt deleted the update-ember-5.2 branch August 31, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants