merge common into monorepo #7597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stopfstedt
commented
Feb 2, 2024
stopfstedt
commented
…r-intl-6.1.1 Bump ember-intl from 6.1.0 to 6.1.1
…flow Replace deprecation workflow
Bumps [ember-simple-charts](https://github.com/ilios/ember-simple-charts) from 10.3.0 to 11.0.1. - [Release notes](https://github.com/ilios/ember-simple-charts/releases) - [Commits](ilios/ember-simple-charts@v10.3.0...11.0.1) --- updated-dependencies: - dependency-name: ember-simple-charts dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…r-simple-charts-11.0.1 Bump ember-simple-charts from 10.3.0 to 11.0.1
Update Transitive Dependencies
Update Transitive Dependencies
We've resolve the upstream and local issues and we can unpin this and move back to tracking embroider releases.
Unpin embroider test versions
18.18.0 has some issues with linux and webpack. Pin an old version for CI for now.
Pin old node version
Bumps [ember-async-data](https://github.com/tracked-tools/ember-async-data) from 1.0.2 to 1.0.3. - [Release notes](https://github.com/tracked-tools/ember-async-data/releases) - [Changelog](https://github.com/tracked-tools/ember-async-data/blob/main/CHANGELOG.md) - [Commits](tracked-tools/ember-async-data@v1.0.2...v1.0.3) --- updated-dependencies: - dependency-name: ember-async-data dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.30 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.30...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ember-cli-mirage](https://github.com/miragejs/ember-cli-mirage) from 3.0.0-alpha.3 to 3.0.0-alpha.5. - [Release notes](https://github.com/miragejs/ember-cli-mirage/releases) - [Changelog](https://github.com/miragejs/ember-cli-mirage/blob/master/CHANGELOG.md) - [Commits](miragejs/ember-cli-mirage@v3.0.0-alpha.3...v3.0.0-alpha.5) --- updated-dependencies: - dependency-name: ember-cli-mirage dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…r-cli-mirage-3.0.0-alpha.5 Bump ember-cli-mirage from 3.0.0-alpha.3 to 3.0.0-alpha.5
Bumps [@embroider/macros](https://github.com/embroider-build/embroider/tree/HEAD/packages/macros) from 1.13.1 to 1.13.2. - [Release notes](https://github.com/embroider-build/embroider/releases) - [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md) - [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/macros) --- updated-dependencies: - dependency-name: "@embroider/macros" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
These toFormat calls were not localized and are not needed anymore, let's replace them with the helper that makes everything much nicer.
We keep running out of screen shots, this limits the number of percy runs we have by requiring a label or manual run.
…oider/macros-1.13.2 Bump @embroider/macros from 1.13.1 to 1.13.2
…css-8.4.31 Bump postcss from 8.4.30 to 8.4.31
…r-async-data-1.0.3 Bump ember-async-data from 1.0.2 to 1.0.3
We've enable this in production (quite a while ago actually) so it can go away here.
This test is flaky and seems to be locale dependent in Safari, maybe this will help.
Releases of firefox, chrome, android, and iOS this year mean we need to tweak our lowest common denominator of browser test versions.
Reduce Percy Runs
Needed to match this up with the one in package.json
Deprecate and replace date formatting getters
Remove sessionLinkingAdminUi flag
The latest version of this doesn't work with legacy decorators, and upstream fix is in, but I'm pinning this while we wait for a release.
Update Transitive Dependencies
The start for required learning material icons got slightly displaced when I updated the way we import and style icons. This puts it back into a visible spot.
Wrong script name, handle it.
None of the non PR run types were actually running because of the test for a label and the PR tests were running on HEAD because this is a pull_request_target workflow. For now I split them into two workflows.
Restore required icon styling
Fix percy workflow
We're changing the name of the frontend app from ilios to frontend as part of migrating to a monorepo setup. For now, hide the back link from both application names.
This command wasn't working as we were targeting the wrong type of file. Fixed it. Whoopsie.
This isn't working with pnpm as it builds node_modules in a different way. We may replace it. Or just remember to run lint before each commit.
Fix style linting
Hide back link for frontend
Remove pre-commit
…spacing prefix workflow files to avoid conflicts when moving to monorepo.
…men_was_zusammen_gehoert
stopfstedt
force-pushed
the
jetzt_waechst_zusammen_was_zusammen_gehoert
branch
from
2a46bcd to
3a7e3ea
Compare
|
Needs to pull the latest commits off of master and then some cleanup in the way common declares it's peer dependencies. I've been playing some tricks to avoid updating things in multiple locations, but now that we're in a monorepo we need to fix up ember date, mirage, moment, and some others. Those commits will be on this PR branch because we need the monorepo setup to check them. |
…ammen_was_zusammen_gehoert
Instead of from npm as we don't publish this anymore we just have it as part of the monorepo.
Rename things back now that they are integration, remove the release management and CI stuff that belonged to common, and integrate common tests into the existing frontend jobs.
Wrong syntax, fixed.
Maybe just a glitch in the way the package manager works, but I think maybe embroider of ember-cli-mirage may also be missing with this on purpose. In either case moving this into being strictly a peer of common so it has to be provided by host apps seems to make embroider much happier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.