Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Support for Safari 15.x #8092

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

jrjohnson
Copy link
Member

@jrjohnson jrjohnson commented Aug 22, 2024

Changing our support to only cover the last two major safari versions on OSX as our stats show that this will cover our users and we can move more quickly to some modern Javascript and improve performance for everyone else by not including dead code.

We wern't able to drop the crypto polyfill because ios Safari doesn't
support it in "insecure" contexts at this version. Hoping that will be
fixed in the future.

stopfstedt
stopfstedt previously approved these changes Aug 22, 2024
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUPERAPPROVED

@stopfstedt stopfstedt dismissed their stale review August 22, 2024 18:54

too soon.

@stopfstedt stopfstedt self-requested a review August 22, 2024 18:54
@jrjohnson jrjohnson marked this pull request as ready for review August 22, 2024 18:55
Changing our support to only cover the last two major safari versions on
OSX as our stats show that this will cover our users and we can move
more quickly to some modern Javascript and improve performance for
everyone else by not including dead code.

We wern't able to drop the crypto polyfill because ios Safari doesn't
support it in "insecure" contexts at this version. Hoping that will be
fixed in the future.
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stopfstedt stopfstedt merged commit 123406c into ilios:master Aug 22, 2024
43 of 44 checks passed
@jrjohnson jrjohnson deleted the drop-safari-15 branch August 22, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants