Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SelectableTermsListItem render modifiers #8306

Conversation

michaelchadwick
Copy link
Contributor

stopfstedt

This comment was marked as outdated.

@dartajax dartajax added the run ui tests Run the expensive UI tests label Jan 11, 2025
@stopfstedt stopfstedt self-requested a review January 11, 2025 01:05
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditional in template needs to be updated, see comment.

@dartajax dartajax removed the run ui tests Run the expensive UI tests label Jan 11, 2025
@dartajax
Copy link
Member

I removed the label for UI tests - will check in the future if / when assigned.

Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stopfstedt stopfstedt added the run ui tests Run the expensive UI tests label Jan 11, 2025
@dartajax dartajax merged commit 19d195b into ilios:master Jan 11, 2025
42 checks passed
@michaelchadwick michaelchadwick deleted the remove-selectable-terms-list-item-render-modifiers branch January 11, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run ui tests Run the expensive UI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants