Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SelectableTermsListItem render modifiers #8306

Merged
merged 3 commits into from
Jan 11, 2025
Merged

Remove SelectableTermsListItem render modifiers #8306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b951e83
removed render modifier
michaelchadwick Jan 11, 2025
b6b5903
updated lint-todo
michaelchadwick Jan 11, 2025
4083b4e
removed conditional
michaelchadwick Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/ilios-common/.lint-todo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ add|ember-template-lint|no-at-ember-render-modifiers|12|6|12|6|9264ba2eca1f85881
add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1731542400000|1762646400000|1793750400000|addon/components/print-course.hbs
add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|aa5aedc5b45db1644928b5b95c2fefc1ef4a7bdf|1731542400000|1762646400000|1793750400000|addon/components/print-course.hbs
add|ember-template-lint|no-at-ember-render-modifiers|12|4|12|4|5ba6894d30ea3a3eae704867d5bc5d61c5ee4e1f|1731542400000|1762646400000|1793750400000|addon/components/search-box.hbs
add|ember-template-lint|no-at-ember-render-modifiers|8|2|8|2|1a2522cd1202904fb09a6e811dec6b46d8189ab3|1731542400000|1762646400000|1793750400000|addon/components/selectable-terms-list-item.hbs
add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|1fb6f249958ee245e6abc413681c9fe096120cef|1731542400000|1762646400000|1793750400000|addon/components/session-copy.hbs
add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|856162ce473b112534763bb641aae7a4422d8e2e|1731542400000|1762646400000|1793750400000|addon/components/session-copy.hbs
add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1731542400000|1762646400000|1793750400000|addon/components/session-offerings-list.hbs
Expand Down
10 changes: 5 additions & 5 deletions packages/ilios-common/addon/components/selectable-terms-list-item.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<button
class="selectable-terms-list-item {{if this.isSelected "selected"}}"
class="selectable-terms-list-item {{if this.isSelected 'selected'}}"
type="button"
data-test-selectable-terms-list-item
data-test-selectable-terms-list-item-level={{this.level}}
{{on "click" this.click}}
{{mouse-hover-toggle (set this "isHovering")}}
{{did-insert (set this "theElement")}}
id={{this.selectableTermsListItemButtonId}}
>
{{#if (and this.theElement this.showTooltip)}}
<IliosTooltip @target={{this.theElement}}>
{{#if this.showTooltip}}
<IliosTooltip @target={{this.selectableTermsListItemButtonElement}}>
{{@term.description}}
</IliosTooltip>
{{/if}}
Expand All @@ -20,4 +20,4 @@
<FaIcon @icon="plus" class="add" />
{{/if}}
</span>
</button>
</button>
12 changes: 10 additions & 2 deletions packages/ilios-common/addon/components/selectable-terms-list-item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
import Component from '@glimmer/component';
import { action } from '@ember/object';
import { tracked } from '@glimmer/tracking';
import { guidFor } from '@ember/object/internals';

export default class SelectableTermsListItem extends Component {
@tracked isHovering;
@tracked theElement;

get selectableTermsListItemButtonId() {
return `selectable-terms-list-item-button-${guidFor(this)}`;
}

get selectableTermsListItemButtonElement() {
return document.getElementById(this.selectableTermsListItemButtonId);
}

get isSelected() {
const term = this.args.term;
Expand All @@ -17,7 +25,7 @@ export default class SelectableTermsListItem extends Component {
}

get showTooltip() {
return this.args?.term.description?.length && this.theElement && this.isHovering;
return this.args?.term.description?.length && this.isHovering;
}

@action
Expand Down
Loading