Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically take action after X seconds (into credits) #200

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dagwieers
Copy link
Collaborator

This PR adds a feature to automatically advance to the next episode after X seconds just as Netflix does.
It is only activated when notification_offset (credits offset) is provided, currently only used by the Netflix add-on.

This replaces #195.

@dagwieers dagwieers added the enhancement New feature or request label Jul 15, 2020
@dagwieers dagwieers added this to the v1.2.0 milestone Jul 15, 2020
@dagwieers dagwieers force-pushed the autoplay-after-credits branch from d7e6fa4 to 4b628f8 Compare July 15, 2020 23:08
@behunin
Copy link

behunin commented Jul 15, 2020

Thank you @dagwieers
Sorry for the headache

@behunin
Copy link

behunin commented Jul 15, 2020

I was thinking that maybe it would be good to add a boolen in api when notification_offset is used. That way show_popup_and_wait doesn't have to load the api data, just check a bool.

@dagwieers dagwieers force-pushed the autoplay-after-credits branch from 4b628f8 to 4c9e146 Compare July 15, 2020 23:28
@dagwieers dagwieers force-pushed the autoplay-after-credits branch from 4c9e146 to 7ea1b23 Compare July 15, 2020 23:44
@dagwieers
Copy link
Collaborator Author

There is more than one problem with the implementation unfortunately:

  • We do not set the correct remaining time, so it no longer shows "Next episode in XX seconds"
  • It doesn't support both notification_time and notification_offset
  • We should probably add some supporting code to make it more readable

This is unfortunately a lot harder to do right than I anticipated 😞

@behunin
Copy link

behunin commented Jul 16, 2020

It doesn't support both notification_time and notification_offset

This is why I suggested adding a bool to api.
See ca3ffb

We do not set the correct remaining time, so it no longer shows "Next episode in XX seconds"

After reasoning about this for a while I see what you mean by this being not so easy after all.
The behavior on the netflix website is just a progress bar with no countdown, so if we just leave it like that then we will give the same experience for the user.

@behunin
Copy link

behunin commented Jul 16, 2020

I think most users will leave the default time to be 6 seconds and if we change the max to be 12 then I think a countdown is not needed. This feature is for the binge watcher that doesn't care what the count is, just that it works and the binge continues. 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants