-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically take action after X seconds (into credits) #200
base: master
Are you sure you want to change the base?
Conversation
d7e6fa4
to
4b628f8
Compare
Thank you @dagwieers |
I was thinking that maybe it would be good to add a boolen in api when notification_offset is used. That way show_popup_and_wait doesn't have to load the api data, just check a bool. |
4b628f8
to
4c9e146
Compare
4c9e146
to
7ea1b23
Compare
There is more than one problem with the implementation unfortunately:
This is unfortunately a lot harder to do right than I anticipated 😞 |
This is why I suggested adding a bool to api.
After reasoning about this for a while I see what you mean by this being not so easy after all. |
I think most users will leave the default time to be 6 seconds and if we change the max to be 12 then I think a countdown is not needed. This feature is for the binge watcher that doesn't care what the count is, just that it works and the binge continues. 🤣 |
This PR adds a feature to automatically advance to the next episode after X seconds just as Netflix does.
It is only activated when notification_offset (credits offset) is provided, currently only used by the Netflix add-on.
This replaces #195.