fix: no russian nesting doll #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The image below is the node modules install folder when installing the sdk. We have some extra stuff we can remove to reduce the size even more when bundling with rollup. For eg, we could remove the src folders of each and the sdk scripts folder, as well as some of the other files in the root of the repo that are not needed. Worth the effort? Can save another half to one mb maybe.
|
zaidarain1
requested changes
Jun 24, 2024
Co-authored-by: zaidarain1 <[email protected]>
zaidarain1
approved these changes
Jun 24, 2024
keithbro-imx
approved these changes
Jun 24, 2024
2 tasks
shineli1984
added a commit
that referenced
this pull request
Jun 26, 2024
This reverts commit b71e361.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make esm module not replicating each other as much as possible.
The size of this approach is ~31 MB vs 37.8MB on npm
Detail and impact of the change
Changed
Group esm package inputs into a rollup config so that roll up can reason about their relationship.