Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to allow manifest-path to be used #7

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

cswindle
Copy link
Contributor

Here is my updated PR which makes the manifest-path optional. I have also switched to output stdout/stderr, rather than hiding it.

@imp
Copy link
Owner

imp commented Nov 28, 2016

I see that you've dropped the output indentation. Was it on purpose ? If so, could you elaborate why please ?

@cswindle
Copy link
Contributor Author

I did not purposely drop the indentation (as I did not realize that you had indentation), although the way that you had previously implemented it meant that it buffered all of the output before dumping stdout at the end, which means that for a long running cargo command there is no feedback on progress and it looks like multi has hung.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants