Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --verbose flag, setting verbose app env option #448

Merged
merged 3 commits into from
Jun 6, 2017
Merged

Add --verbose flag, setting verbose app env option #448

merged 3 commits into from
Jun 6, 2017

Conversation

srenatus
Copy link
Contributor

@srenatus srenatus commented Jun 6, 2017 •
edited
Loading

Now with the corresponding elvis_core PR, it'll behave as follows:

$ elvis --output-format plain --verbose rock
Loading files...
Loading src/elvis.erl
Loading src/elvis_git.erl
Loading src/elvis_webhook.erl
Loading test/elvis_SUITE.erl
Loading test/elvis_meta_SUITE.erl
Loading test/git_SUITE.erl
Loading test/xref_SUITE.erl
Applying rules...
# src/elvis.erl [FAIL]
  - no_tabs
    - Line 18 has a tab at column 0.
# src/elvis_git.erl [OK]
# src/elvis_webhook.erl [OK]
# test/elvis_SUITE.erl [OK]
# test/elvis_meta_SUITE.erl [OK]
# test/git_SUITE.erl [OK]
# test/xref_SUITE.erl [OK]
Loading files...
Applying rules...
Loading files...
Loading rebar.config
Applying rules...
# rebar.config [OK]
Loading files...
Loading elvis.config
Applying rules...
# elvis.config [OK]
$

vs

$ elvis --output-format plain rock
# src/elvis.erl [FAIL]
  - no_tabs
    - Line 18 has a tab at column 0.
$

I've also thought that it might make sense to expose the existing no_output app env setting, via -q:

$ elvis -q rock
$ echo $?
1
$

srenatus added 3 commits June 6, 2017 09:48
@srenatus
add --verbose flag, setting verbose app env option
439190b 
Signed-off-by: Stephan Renatus <[email protected]>
@srenatus
clarify --version option
368f220 
Signed-off-by: Stephan Renatus <[email protected]>
@srenatus
add -q (--quiet) option
671e98e 
This would suppress _all output_ -- exposing an elvis app env var that
already exists.

Signed-off-by: Stephan Renatus <[email protected]>
@srenatus
Copy link
Contributor Author

srenatus commented Jun 6, 2017

Fixes #447.

@srenatus srenatus mentioned this pull request Jun 6, 2017
Merged
@elbrujohalcon elbrujohalcon merged commit 2a42880 into inaka:master Jun 6, 2017
@srenatus srenatus deleted the sr/add-verbosity-to-cli-options branch June 6, 2017 13:18
@srenatus srenatus mentioned this pull request Jun 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srenatus @elbrujohalcon