add verbosity config option, output only errors unless set #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadgetci
reviewed
Jun 6, 2017
src/elvis_utils.erl
Outdated
|
|
||
| -spec error(string()) -> ok. | ||
| error(Message) -> | ||
| error(Message, []). |
There was a problem hiding this comment.
According to Compiler:
Warning: ambiguous call of overridden auto-imported BIF error/2
`elvis_utils:print_info` will be suppressed when verbose is _not_ set. Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/add-verbosity-to-config
branch
from
162b73d to
a65b524
Compare
elbrujohalcon
approved these changes
Jun 6, 2017
elbrujohalcon
requested changes
Jun 6, 2017
|
@elbrujohalcon I've actually wondered how this didn't break tests... I'm looking into adding some 👍 |
|
@srenatus that's probably because we lost 100% coverage when we split elvis and elvis_core =/ |
… set Signed-off-by: Stephan Renatus <[email protected]>
elbrujohalcon
approved these changes
Jun 6, 2017
|
Thanks @srenatus !! |
|
@elbrujohalcon my pleasure -- thanks for being open to suggestions even when they change the defaults 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elvis_utils:print_infowill be suppressed whenverboseis not set.elvis_utils:errorcan only be suppressed by settingno_output.