Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations file #121

Closed
6 of 7 tasks
soriadelva opened this issue Apr 15, 2024 · 7 comments · Fixed by #142
Closed
6 of 7 tasks

Update translations file #121

soriadelva opened this issue Apr 15, 2024 · 7 comments · Fixed by #142
Assignees
Labels
enhancement New feature or request

Comments

@soriadelva
Copy link
Contributor

soriadelva commented Apr 15, 2024

Write descriptions for:

  • ...

Add the following ID's, with respective translations & descriptions:

  • createReport: Button to create a pdf report of a single species page
  • occupancy: Generalised (intersected with a grid) area occupied by a species
  • management3-countYearGroup: Management split per group
  • apply_gamObservations: Trias GAM based on observations
  • apply_gamOccupancy: Trias GAM based on occupancy

Rework the translation of the following ID's:

  • global_indicators: Global indicators -> Checklist indicators
@SanderDevisscher
Copy link
Collaborator

@SanderDevisscher
Copy link
Collaborator

SanderDevisscher commented Apr 18, 2024

The following ID's should be added to the translation file, with respective translations & descriptions:

  • createReport: Button to create a pdf report of a single species page (only ID)
  • occupancy: Generalised (intersected with a grid) area occupied by a species (ID +Description)
  • management3-countYearGroup: Management split per group (ID + Description)
  • apply_gamObservations: Trias GAM based on observations (ID + Description)
  • apply_gamOccupancy: Trias GAM based on occupancy (ID + Description)

@SanderDevisscher SanderDevisscher added the enhancement New feature or request label Apr 18, 2024
@SanderDevisscher
Copy link
Collaborator

SanderDevisscher commented Apr 18, 2024

@mvarewyck the alienspecies app flags amongst others these as not present in the translation file:

  • bottom
  • top
  • right
  • left
  • summarizeBy
  • 'S Gravenbrakel, Aalst, Aalter, ...
  • t0
  • t1

I would suggest splitting the translation file into 2, namely:

  1. translations: current translation file excluding part that should be in the other file
  2. translations_simple: translations for amongst others communes, provinces & regions and IDs needing only a translation and no description (this file would have only 4 fields: ID;EN;NL;FR)

What do you think ?

@mvarewyck
Copy link
Collaborator

@SanderDevisscher Sure, fine for me to split the file.
Some remarks:

mvarewyck added a commit that referenced this issue Apr 26, 2024
mvarewyck added a commit that referenced this issue Apr 26, 2024
@mvarewyck
Copy link
Collaborator

mvarewyck commented Apr 26, 2024

I have created 3 files for the translations:

  • translations.csv: Columns for ID, title and description. Used for records that need to tie a description to the translated title (E.g. graphs in app)
  • translations_simple.csv: Columns for ID and title. Simple translations in 3 languages (E.g. labels/choice options in app)
  • translations_regions.csv: Columns for ID and title. Only for geographical regions (E.g. municipalities). Translations are not required for all 3 languages. If a translation is missing, the dutch translation is taken automatically. I have created a function which can create this file based on all regions used in the app for reference

@soriadelva Do we need to document this somewhere?

mvarewyck added a commit to inbo/alien-species-portal that referenced this issue Apr 26, 2024
mvarewyck added a commit that referenced this issue Apr 26, 2024
@mvarewyck
Copy link
Collaborator

mvarewyck commented Apr 26, 2024

@soriadelva the translation files should be ready now to

  • complete missing translations in translations_simple.csv (indicated by TODO)
  • complete missing translations for the regions in translations_regions.csv. If translation is missing I now take the dutch one (title_nl).
  • rework translations as requested above by Sander

@soriadelva
Copy link
Contributor Author

I have created 3 files for the translations:

  • translations.csv: Columns for ID, title and description. Used for records that need to tie a description to the translated title (E.g. graphs in app)
  • translations_simple.csv: Columns for ID and title. Simple translations in 3 languages (E.g. labels/choice options in app)
  • translations_regions.csv: Columns for ID and title. Only for geographical regions (E.g. municipalities). Translations are not required for all 3 languages. If a translation is missing, the dutch translation is taken automatically. I have created a function which can create this file based on all regions used in the app for reference

@soriadelva Do we need to document this somewhere?

@mvarewyck I will add this to the wiki under the information of the files in UAT_ direct 👌

@soriadelva soriadelva linked a pull request Apr 29, 2024 that will close this issue
mvarewyck added a commit to inbo/alien-species-portal that referenced this issue May 2, 2024
mvarewyck added a commit to inbo/alien-species-portal that referenced this issue May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants