Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasks): distinguish template tasks in task list #5807

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Sep 6, 2021

This PR visually distinguishes tasks that were created from a template in a chronograf task list.

Before this PR
and before influxdata/kapacitor#2621 is merged:

  1. A template task is processed on the chronograf server-side to check if it is a rule. It is never in fact.
    1. If a template task is recognized as a chronograf rule, it falsely appears under Alert Rules section.
  2. A template task correctly appears in a TICKScripts section. It is however not distinguished from regular tasks that are editable, a template task is not.

image

After this PR
and after influxdata/kapacitor#2621 is merged:

  1. A template task is never processed on the chronograf server-side to check if it is a rule. It cannot appear in Alert Rules section.
  2. Tickscript of a template task is visually recognized. It is read-only in chronograf since fix(kapacitor): make templated kapacitor task read-only #5805 .

image

Sorry, something went wrong.

@sranka sranka force-pushed the feat/distinguish_templated_tasks branch from 6a17327 to f6bad42 Compare September 6, 2021 05:47
@sranka sranka requested a review from ivankudibal September 6, 2021 06:24
@sranka sranka marked this pull request as ready for review September 6, 2021 06:24
@sranka sranka merged commit e78121d into master Sep 28, 2021
@sranka sranka deleted the feat/distinguish_templated_tasks branch September 28, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants