feat(tasks): add template-id to task list #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sranka
changed the title
sranka
force-pushed
the
2619/list_with_template_id
branch
from
7ac3709 to
70e0aa5
Compare
4 tasks
lesam
reviewed
Sep 7, 2021
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/google/go-cmp/cmp" |
There was a problem hiding this comment.
VS.Code linter warned about the usage of reflect.DeepEqual. It was probably a false warning since the reflect.DeepEqual caveats did not apply to the cases used in the test. I appeased the linter, https://pkg.go.dev/github.com/google/go-cmp/cmp should be rather used in tests.
lesam
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2619
This PR adds template-id OOTB to the list of returned tasks. It includes also tests, an updated swagger file, and housekeeping of staticcheck errors on updated files.
Adding template-id to task list helps chronograf with processing and visualization of templated tasks. Details are explained in influxdata/chronograf#5807
Required for all non-trivial PRs