-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: delete the go formatter code as it is not longer used #3998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, are you going to also make sure that the other repositories that use Flux can still build with the Go formatter removed?
@@ -13,6 +13,7 @@ import ( | |||
|
|||
"github.com/influxdata/flux" | |||
"github.com/influxdata/flux/ast" | |||
"github.com/influxdata/flux/ast/astutil" | |||
"github.com/influxdata/flux/ast/edit" | |||
"github.com/influxdata/flux/codes" | |||
"github.com/influxdata/flux/csv" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an aside, I don't think we need this code anymore... we should delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I don't mean for you to delete as part of this PR)
I can see go formatter reference in idpe, kapacitor and query-archiver I have sent a message on bulletins and will make sure all the references are replaced before merging this PR. |
Kapacitor switching over to the new formatter in influxdata/kapacitor#2618 |
@danxmoran I can still see 2 occurrences of it in the kapacitor repository. https://github.com/influxdata/kapacitor/search?q=ast.format Kindly have a look and let me know. |
The remaining occurrences of |
Thanks @danxmoran, will merge this PR then. |
removed ast/format.go and ast/format_test.go also removed test_rewriter package as its not longer in use
9afdb96
to
552533b
Compare
removed ast/format.go and ast/format_test.go
also removed test_rewriter package as its not longer in use