fix: switch flux formatter to one that preserves comments #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Aug 31, 2021
danxmoran
commented
Aug 31, 2021
danxmoran
commented
Aug 31, 2021
skartikey
reviewed
Sep 1, 2021
lesam
approved these changes
Sep 1, 2021
|
LGTM but would be nice to at least move the protobuf stuff up to the edge container and pull in the Duration formatting fix. |
danxmoran
force-pushed
the
dm-switch-flux-formatters-2617
branch
from
c261a5c to
c97ff3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs