-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notification/teams): add teams notification #18916
Conversation
The PR could be merged after #18218, small conflicts are expected. |
581fea8
to
3c1f2c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you split this into two prs (front/back-end) or feature flag the front-end code as it tends to be deployed first
@glinton ... sure, can you please first
|
I'm not certain why that was reverted, so i don't want to un-revert it. My guess is that you'll need to split up that work into 2 prs also, one for the backend code, and one for the front for the same reasons as mentioned above. Reach out to those involved in the revert if you'd like to learn more.
I commented on the pr, but can you add tests to show the behavior described and that the new code fixes that. otherwise it looks like a sane change |
@glinton ... I have to wait herein for the telegram to be re-introduced back into master, the other way would be painful. I changed this PR to draft because of it. |
0bc51d6
to
82ca912
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go code looks good. I'll let someone with more front-end experience approve the pr after the front-end code is reviewed
567728f
to
a66387b
Compare
This PR cannot be approved and merged anymore, it contains both UI and server part that are in now different repositories. Two PRs are required now. |
Closes #17939
This PR adds support for Microsoft Teams in InfluxDB notification endpoints and notification rules. It depends on influxdata/flux#2866 that introduces a new teams package to send notifications.
What is in this PR
What is not in this PR