Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagerduty alert handler should allow customizing details #743

Open
phemmer opened this issue Jul 22, 2016 · 2 comments
Open

Pagerduty alert handler should allow customizing details #743

phemmer opened this issue Jul 22, 2016 · 2 comments

Comments

@phemmer
Copy link

phemmer commented Jul 22, 2016

Right now the pagerduty handler is hard-coded to send the alert data in the details field. This data is not very useful as the way it is formatted (non-prettified json) is very hard to read (it's hard to match a value in .values with a name in .columns, and the pagerduty details field is meant to be human readable). Instead the details field should be able to be customized. Some of the other handlers use the .details attribute of the alert, though the documentation seems to emphasize that .details is meant to be html, where as pagerduty's "details" field is arbitrary data. So I guess the options are to either use this field ignoring the html bit, or provide a new node key that can be used.

While we're at it, pagerduty has another field, contexts, that would be useful to be able to set as well.

@nathanielc
Copy link
Contributor

@phemmer I think the details fields is a good fit here. Kapacitor never consumes the data in the details field, it only produces it. While the details can be HTML the intent is that it is human consumable information.

I would accept a PR that makes use of the .details property for pagerduty's details field.

@andrewthad
Copy link

I have made this change at #2297.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants