Use details field from alert node in pagerduty #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phemmer your thoughts would be appreciated. |
|
Seems straightforward enough. Lets |
nathanielc
reviewed
Aug 4, 2017
integrations/streamer_test.go
Outdated
| @@ -7844,6 +7844,7 @@ stream | |||
| .info(lambda: "count" > 6.0) | |||
| .warn(lambda: "count" > 7.0) | |||
| .crit(lambda: "count" > 8.0) | |||
| .details('details') | |||
There was a problem hiding this comment.
Why change the test here? I'd like to test that the default behavior is not changed. Meaning if details is not specified that the pageDuty handler remains the same.
desa
commented
Aug 4, 2017
| @@ -7828,6 +7828,8 @@ func TestStream_AlertPagerDuty(t *testing.T) { | |||
| ts := pagerdutytest.NewServer() | |||
| defer ts.Close() | |||
|
|
|||
| defaultDetails := "{"Name":"cpu","TaskName":"TestStream_Alert","Group":"host=serverA","Tags":{"host":"serverA"},"ServerInfo":{"Hostname":"","ClusterID":"","ServerID":""},"ID":"kapacitor/cpu/serverA","Fields":{"count":10},"Level":"CRITICAL","Time":"1971-01-01T00:00:10Z","Message":"CRITICAL alert for kapacitor/cpu/serverA"}\n" | |||
There was a problem hiding this comment.
This is the default format that gets generated.
|
@nathanielc this should be ready to review again. Also, once this is done should I cherry pick it onto master? |
nathanielc
approved these changes
Aug 8, 2017
|
kk |
|
Whoops. Just realized i didn't update the changelog. Going to open another PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #743
Previously the details field specified on an alert node was not being used in the pagerduty service. Instead, the results object that generated was being used. This PR now uses the details field specified.
@nathanielc is this all, or is there something I'm missing?
Required for all non-trivial PRs