fix(teams): revert ChannelURL mapping to preserve BC with saved TICKscripts #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity with saved TICKscripts
sranka
force-pushed
the
revert/2545_pipeline_alert
branch
from
d28eb05 to
f2f4cd3
Compare
docmerlin
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts consistent ChannelURL JSON mapping introduced in #2545, it would cause anyone who has Teams Pipeline saved to lose that field from their pipeline.
In order to preserve backward compatibility, MS Teams ChannelURL has to remain
channel_urlin TICKscript andchannel-urlin the config. This discrepancy requires an extra care in chronograf 1.9 that added Teams alert/configuration UI.