Greg/ci exclusions #310
Greg/ci exclusions #310
Conversation
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
======================================
Coverage 30.5% 30.5%
======================================
Files 127 127
Lines 4580 4580
Branches 1416 1416
======================================
Hits 1398 1398
Misses 2215 2215
Partials 967 967 Continue to review full report at Codecov.
|
| - Moved to GitHub Actions ([#120](https://github.com/informalsystems/tendermint-rs/issues/120)) | ||
| - Updated crates.io badges ([#120](https://github.com/informalsystems/tendermint-rs/issues/120)) | ||
| - Enabled integration tests in CI with Tendermint-Go node service ([#120](https://github.com/informalsystems/tendermint-rs/issues/120)) | ||
| - Removed docs folder from CI execution ([#309](https://github.com/informalsystems/tendermint-rs/issues/309)) |
There was a problem hiding this comment.
General remark: Do we really want to mention every CI improvement in the Changelog? It does not affect anyone using of this repo.
There was a problem hiding this comment.
LOL, we don't need to, I'm just a busybody. I actually never know what we should mention about CI, because it doesn't affect anyone outside the developers of the repository.
When we cut a release, we can clean this up. I think it's worth keeping them in pending, so developers are aware.
There was a problem hiding this comment.
I also felt weird adding CI improvements to the changelog, but did it to follow existing precedent.
But Greg's certainly right that devs should be kept abreast of developments in our CI. Maybe it would make sense to have a separate changelog for the devenv (inclusive of all CI/CD) -- since it's a piece of software in its own right, whose users are any and all contributors.
There was a problem hiding this comment.
(Oh man -- sorry for the super tardy reply here... I am cleaning out my inbox and didn't check the context/dates before replying 🤦 )
Fixes #309