Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greg/ci exclusions #310

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Greg/ci exclusions #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dde6e90
Exclude CI builds when only docs folder changed.
greg-szabo Jun 9, 2020
83ec896
Updated CHANGELOG
greg-szabo Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
name: Rust
on:
pull_request:
paths-ignore:
- 'docs/**'
push:
branches:
- master
paths-ignore:
- 'docs/**'
branches:
- master
jobs:
cleanup-runs:
runs-on: ubuntu-latest
Expand Down
9 changes: 5 additions & 4 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@ RPC:
- serialization/deserialization fixes
- Updated/fixed integration tests

CI: ([#120](https://github.com/informalsystems/tendermint-rs/issues/120))
- Moved to GitHub Actions
- Updated crates.io badges
- Enabled integration tests in CI with Tendermint-Go node service
CI:
- Moved to GitHub Actions ([#120](https://github.com/informalsystems/tendermint-rs/issues/120))
- Updated crates.io badges ([#120](https://github.com/informalsystems/tendermint-rs/issues/120))
- Enabled integration tests in CI with Tendermint-Go node service ([#120](https://github.com/informalsystems/tendermint-rs/issues/120))
- Removed docs folder from CI execution ([#309](https://github.com/informalsystems/tendermint-rs/issues/309))
Copy link
Member

@liamsi liamsi Jun 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General remark: Do we really want to mention every CI improvement in the Changelog? It does not affect anyone using of this repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, we don't need to, I'm just a busybody. I actually never know what we should mention about CI, because it doesn't affect anyone outside the developers of the repository.

When we cut a release, we can clean this up. I think it's worth keeping them in pending, so developers are aware.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also felt weird adding CI improvements to the changelog, but did it to follow existing precedent.

But Greg's certainly right that devs should be kept abreast of developments in our CI. Maybe it would make sense to have a separate changelog for the devenv (inclusive of all CI/CD) -- since it's a piece of software in its own right, whose users are any and all contributors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Oh man -- sorry for the super tardy reply here... I am cleaning out my inbox and didn't check the context/dates before replying 🤦 )


## [0.13.0] (2020-04-20)

Expand Down