feat: Update wasm::Module to enable wasm component model [try 2] #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenj
reviewed
Feb 9, 2024
Mr-Leshiy
force-pushed
the
feat/hermes-executor
branch
from
6ef08e4 to
aed5512
Compare
Mr-Leshiy
requested review from
FelipeRosa,
cong-or,
saibatizoku and
minikin
as code owners
Mr-Leshiy
added
review me
8 tasks
8 tasks
8 tasks
8 tasks
8 tasks
8 tasks
This was referenced Mar 29, 2024
8 tasks
8 tasks
8 tasks
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated current wasm::Module implementation to be aligned with the WASM component model design
Related Issue(s)
Part of #79
Description of Changes
event::HermesEventPayloadtrait as a Hermes event abstraction.wasm::Moduleimplementation. Made it a WASM component centric.wasm::Moduleincapsulates the logic around "How to load wasm module", "How to prepare a WASM environment for every execution of the wasm module. Alsowasm::Moduledoes not responsible and does not answering the question "How to execute wasm function", this functionality is generalised with the help ofwasm::module::Instancetrait andevent::HermesEventPayloadtrait.