Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consul registry deregister all unknown services, including services registered not with pinchy #8

Closed
insidieux opened this issue Dec 26, 2020 · 0 comments · Fixed by #9
Closed

Consul registry deregister all unknown services, including services registered not with pinchy #8

insidieux opened this issue Dec 26, 2020 · 0 comments · Fixed by #9
Assignees
@insidieux
Labels
bug Something isn't working

Comments

@insidieux
Copy link
Owner

Describe the bug

Consul registry deregister all unknown services, including services registered not with pinchy.

To Reproduce

  • Run empty consul cluster
  • Register service "service-1" via API
  • Prepare services.yml file with "service-2"
  • Run pinchy

Expected behavior

Service "service-1" must present at cluster.

Environment:

  • Version: v1.0.0
  • GOOS: linux

Additional context

  • Need to fix bug
  • Need to update user guide documentation about how to run pinchy: list of available flags
@insidieux insidieux added the bug Something isn't working label Dec 26, 2020
@insidieux insidieux self-assigned this Dec 26, 2020
insidieux added a commit that referenced this issue Dec 26, 2020
@insidieux
Fix #8
6763f09 
- Fix bug with deregister non pinchy services
- Update user guide documentation
- Add logs in file source
- Add logs in consul registry
- Add docker-compose example for pinhcy
- Remove image push to github docker registry
- Push docker image to docker hub registry for branches (latest only for tags)
@insidieux insidieux mentioned this issue Dec 28, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@insidieux insidieux

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 8 insidieux/pinchy
1 participant
@insidieux