Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 8 #9

Merged
merged 3 commits into from
Dec 28, 2020
Merged

Issue 8 #9

merged 3 commits into from
Dec 28, 2020

Conversation

insidieux
Copy link
Owner

Description

Fixes #8

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

  • This PR contains documentation
  • This PR contains tests
  • This PR has been tested for backwards compatibility

- Fix bug with deregister non pinchy services
- Update user guide documentation
- Add logs in file source
- Add logs in consul registry
- Add docker-compose example for pinhcy
- Remove image push to github docker registry
- Push docker image to docker hub registry for branches (latest only for tags)
@insidieux insidieux self-assigned this Dec 28, 2020
@codecov-io
Copy link

codecov-io commented Dec 28, 2020

Codecov Report

Merging #9 (8f49f1c) into master (8c1fd56) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          179       201   +22     
=========================================
+ Hits           179       201   +22     
Impacted Files Coverage Δ
pkg/core/manager.go 100.00% <100.00%> (ø)
pkg/core/registry/consul/registry.go 100.00% <100.00%> (ø)
pkg/core/service.go 100.00% <100.00%> (ø)
pkg/core/source/file/source.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1fd56...8f49f1c. Read the comment docs.

@insidieux insidieux merged commit e6f28d3 into master Dec 28, 2020
@insidieux insidieux deleted the issue-8 branch December 28, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consul registry deregister all unknown services, including services registered not with pinchy
2 participants