switch to r-lib/actions/setup-r-dependencies@v2
#274
Conversation
Unit Tests Summary3 tests 3 ✅ 6s ⏱️ Results for commit ba60dbe. ♻️ This comment has been updated with latest results. |
| @@ -441,7 +441,7 @@ jobs: | |||
| if: >- | |||
| env.deps_installation_method == 'setup-r-dependencies' | |||
| && inputs.install-deps-from-package-repositories == '' | |||
| uses: insightsengineering/setup-r-dependencies@v1 | |||
| uses: r-lib/actions/setup-r-dependencies@v2 | |||
There was a problem hiding this comment.
in lines below this we need to adjust the parameters
There was a problem hiding this comment.
unresolving this as this is still applicable
this action cannot use r-lib/actions/setup-r-dependencies@v2 and pass lookup-refs and other custom parameters
There was a problem hiding this comment.
the same applies for other places - we need to make sure that we call that action with supported parameters
There was a problem hiding this comment.
yes, so this PR is ready to go, just all other repos can't pass
- repository-list
- lookup-refs
- skip-desc-dev
- skip-desc-branch
There was a problem hiding this comment.
Also removed those parameters from actual job configurations b9096a7
|
These are good changes but not complete as of now. |
|
I'll be testing with this teal PR insightsengineering/teal#1466 |
by |
All where necessary. Obviously these live in our org and include also tern and family etc. |
…nor in r-hub/actions/setup-deps
|
@pawelru so far I adjusted possible inputs that are passed to |
| env: | ||
| GITHUB_PAT: ${{ steps.github-token.outputs.token }} | ||
| with: | ||
| lookup-refs: ${{ inputs.lookup-refs }} | ||
| repository-path: ${{ github.event.repository.name }}/${{ inputs.package-subdirectory }} |
There was a problem hiding this comment.
@pawelru do you think we also should remove repository-path?
r-lib/actions/setup-r-dependencies@v2 does not support this
If we need this, then I guess we need to stick with insightsengineering/setup-r-dependencies@v1
There was a problem hiding this comment.
from what I can see there is a working-directory parameter so we can pass it there
| skip-install: true | ||
| restore-description: false |
There was a problem hiding this comment.
@pawelru similar to this conversation https://github.com/insightsengineering/r.pkg.template/pull/274/files#r1935570098
skip-install and restore-description are not part of r-lib/actions/setup-r-dependencies@v2
Should we remove those? Can we remove those? If we need those, should we stick to insightsengineering/setup-r-dependencies@v1
There was a problem hiding this comment.
this is definitely to be removed - it's very specific to the logic of ie/setup-r-deps
Co-authored-by: Pawel Rucki <[email protected]> Signed-off-by: Marcin <[email protected]>
Part of https://github.com/insightsengineering/coredev-tasks/issues/609