Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vbump teal.data #1466

Merged
merged 6 commits into from
Jan 30, 2025
Merged

vbump teal.data #1466

merged 6 commits into from
Jan 30, 2025

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 29, 2025

Bumping teal.data

Signed-off-by: Marcin <[email protected]>
@m7pr m7pr added the core label Jan 29, 2025
@m7pr m7pr requested a review from donyunardi January 29, 2025 10:08
Signed-off-by: Marcin <[email protected]>
@m7pr
Copy link
Contributor Author

m7pr commented Jan 29, 2025

Hey @pawelru we vbumped teal.data in here to the newest CRAN released version.
Now I see dependency conflict in staged-r-dependencies scenario dependency installation.
Do you think we should also remove lookup-refs, as we did remove Remotes, if a package depends on a CRAN-released version?

And only bring back Remotes and lookup-refs once the package relies on a development version again?

@m7pr
Copy link
Contributor Author

m7pr commented Jan 29, 2025

I see the same package installation conflicts in

@pawelru
Copy link
Contributor

pawelru commented Jan 29, 2025

I can see in the log that there are some conflicting entires that prevents dependency solver to succeed. This is true for all the PRs you referenced. In here it is:

  Remotes:
      insightsengineering/teal.slice
  Config/Needs/DepsBranch:
      insightsengineering/teal.slice@vbump_tealdata@main

.github/workflows/check.yaml Outdated Show resolved Hide resolved
.github/workflows/check.yaml Outdated Show resolved Hide resolved
.github/workflows/check.yaml Outdated Show resolved Hide resolved
.github/workflows/check.yaml Outdated Show resolved Hide resolved
.github/workflows/docs.yaml Outdated Show resolved Hide resolved
.github/workflows/scheduled.yaml Outdated Show resolved Hide resolved
.github/workflows/scheduled.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Unit Tests Summary

  1 files   28 suites   10m 43s ⏱️
278 tests 274 ✅ 4 💤 0 ❌
540 runs  536 ✅ 4 💤 0 ❌

Results for commit 8c88637.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💔 $129.70$ $+3.16$ $0$ $0$ $0$ $0$

Results for commit 49ac8ce

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor Author

m7pr commented Jan 30, 2025

@pawelru I decided to remove lookup-refs to avoid collision of Remotes fields and DepsDev/DepsBranch.
Still on ie/setup-r-dependencies@v1 job, but at some point we will move to r-lib/actions/setup-r-dependencies@v2 in here insightsengineering/r.pkg.template#274

I also removed lookup-refs in tmg and tmc

insightsengineering/teal.modules.general#836
insightsengineering/teal.modules.clinical#1326

@m7pr m7pr merged commit 4bc538d into main Jan 30, 2025
29 checks passed
@m7pr m7pr deleted the vbump_tealdata@main branch January 30, 2025 09:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants