Skip to content

Commit

Permalink
Remove lookup-refs (#286)
Browse files Browse the repository at this point in the history
**Blocked by release -
#285

Part of insightsengineering/coredev-tasks#609

From now on, we will provide development dependencies in 
```
Remotes: repo/project@branch
```
format, so it's explicitly visible in the DESCRIPTION file and can be
handled by `pak::install`, `renv::install` and `remotes::install`.

With development dependencies specified in CJ Pipelines configuration,
this connection was hidden, and it was hard to install the package from
the main branch (or any other branch) locally from user's machine.
  • Loading branch information
m7pr authored Jan 31, 2025
1 parent 66d738d commit d1c691d
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 35 deletions.
12 changes: 0 additions & 12 deletions .github/workflows/check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ jobs:
unit-test-report-brand: >-
https://raw.githubusercontent.com/insightsengineering/hex-stickers/main/thumbs/teal.png
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/formatters
insightsengineering/rtables

r-cmd-non-cran:
name: R CMD Check (non-CRAN) 🧬
Expand All @@ -68,9 +65,6 @@ jobs:
checking for unstated dependencies in vignettes .* NOTE
checking top-level files .* NOTE
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/formatters
insightsengineering/rtables
coverage:
name: Coverage πŸ“”
uses: insightsengineering/r.pkg.template/.github/workflows/test-coverage.yaml@main
Expand All @@ -80,9 +74,6 @@ jobs:
additional-env-vars: |
NOT_CRAN=true
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/formatters
insightsengineering/rtables

linter:
if: github.event_name != 'push'
Expand All @@ -96,9 +87,6 @@ jobs:
with:
auto-update: true
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/formatters
insightsengineering/rtables
gitleaks:
name: gitleaks πŸ’§
uses: insightsengineering/r.pkg.template/.github/workflows/gitleaks.yaml@main
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,3 @@ jobs:
default-landing-page: latest-tag
additional-unit-test-report-directories: unit-test-report-non-cran
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/formatters
insightsengineering/rtables
12 changes: 0 additions & 12 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ jobs:
with:
default-landing-page: latest-tag
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/formatters
insightsengineering/rtables
validation:
name: R Package Validation report πŸ“ƒ
needs: release
Expand All @@ -28,9 +25,6 @@ jobs:
REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }}
with:
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/formatters
insightsengineering/rtables
release:
name: Create release πŸŽ‰
uses: insightsengineering/r.pkg.template/.github/workflows/release.yaml@main
Expand All @@ -56,9 +50,6 @@ jobs:
unit-test-report-brand: >-
https://raw.githubusercontent.com/insightsengineering/hex-stickers/main/thumbs/teal.png
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/formatters
insightsengineering/rtables
coverage:
name: Coverage πŸ“”
needs: [release, docs]
Expand All @@ -69,9 +60,6 @@ jobs:
additional-env-vars: |
NOT_CRAN=true
deps-installation-method: setup-r-dependencies
lookup-refs: |
insightsengineering/formatters
insightsengineering/rtables
wasm:
name: Build WASM packages πŸ§‘β€πŸ­
needs: release
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ jobs:
)
name: revdepcheck ↩️
uses: insightsengineering/r.pkg.template/.github/workflows/revdepcheck.yaml@main
with:
lookup-refs: |
insightsengineering/formatters
insightsengineering/rtables
rhub:
if: >
github.event_name == 'schedule' || (
Expand All @@ -69,7 +65,3 @@ jobs:
)
name: R-hub 🌐
uses: insightsengineering/r.pkg.template/.github/workflows/rhub.yaml@main
with:
lookup-refs: |
insightsengineering/formatters
insightsengineering/rtables

0 comments on commit d1c691d

Please sign in to comment.