Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lookup-refs #286

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Remove lookup-refs #286

merged 2 commits into from
Jan 31, 2025

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 30, 2025

Blocked by release - #285

Part of https://github.com/insightsengineering/coredev-tasks/issues/609

From now on, we will provide development dependencies in

Remotes: repo/project@branch

format, so it's explicitly visible in the DESCRIPTION file and can be handled by pak::install, renv::install and remotes::install.

With development dependencies specified in CJ Pipelines configuration, this connection was hidden, and it was hard to install the package from the main branch (or any other branch) locally from user's machine.

Copy link

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@m7pr m7pr removed the blocked label Jan 31, 2025
@m7pr m7pr removed the request for review from pawelru January 31, 2025 09:52
@m7pr m7pr marked this pull request as ready for review January 31, 2025 09:52
@m7pr m7pr enabled auto-merge (squash) January 31, 2025 09:52
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Unit Tests Summary

  1 files   11 suites   1m 26s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
334 runs  334 ✅ 0 💤 0 ❌

Results for commit 2c390f9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
plot_with_settings_ui 💚 $43.14$ $-2.37$ $0$ $0$ $0$ $0$
table_with_settings_ui 💚 $32.77$ $-1.04$ $0$ $0$ $0$ $0$

Results for commit 71b873b

♻️ This comment has been updated with latest results.

@m7pr m7pr merged commit d1c691d into main Jan 31, 2025
49 checks passed
@m7pr m7pr deleted the remove_lookups branch January 31, 2025 09:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants