-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename blockchain connector type to application #397
Merged
jvallesm
merged 5 commits into
main
from
jvalles/ins-3739-rename-blockhain-type-to-application
Feb 27, 2024
Merged
feat: rename blockchain connector type to application #397
jvallesm
merged 5 commits into
main
from
jvalles/ins-3739-rename-blockhain-type-to-application
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
=====================================
Coverage 0.70% 0.70%
=====================================
Files 8 8
Lines 2973 2960 -13
=====================================
Hits 21 21
+ Misses 2952 2939 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvallesm
commented
Feb 27, 2024
jvallesm
commented
Feb 27, 2024
jvallesm
commented
Feb 27, 2024
56624de
to
fc77cb4
Compare
jvallesm
commented
Feb 27, 2024
jvallesm
commented
Feb 27, 2024
✅ QA
Additionally, I tested the API endpoint: $ curl --request GET \
--url 'localhost:8080/vdp/v1beta/connector-definitions?view=VIEW_BASIC&filter=connector_type=CONNECTOR_TYPE_APPLICATION' \
--header 'accept: application/json' \
--header 'Authorization: Bearer insXXX' | jq
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 699 100 699 0 0 16364 0 --:--:-- --:--:-- --:--:-- 16642
{
"connector_definitions": [
{
"name": "connector-definitions/numbers",
"uid": "70d8664a-d512-4517-a5e8-5d4da81756a7",
"id": "numbers",
"title": "Numbers Protocol",
"documentation_url": "https://www.instill.tech/docs/latest/vdp/app-connectors/numbers-protocol",
"icon": "assets/numbers.svg",
"spec": null,
"type": "CONNECTOR_TYPE_APPLICATION",
"tombstone": false,
"public": true,
"custom": false,
"vendor": "Numbers Protocol",
"vendor_attributes": null,
"source_url": "https://github.com/instill-ai/connector/blob/main/pkg/numbers/v0",
"version": "0.1.0-alpha",
"tasks": [
{
"name": "TASK_REGISTER",
"title": "Register",
"description": "Register a file into NumbersProtocol Chain."
}
]
}
],
"next_page_token": "",
"total_size": 1
}
$ curl --request GET \
--url 'localhost:8080/vdp/v1beta/connector-definitions?view=VIEW_BASIC&filter=connector_type=CONNECTOR_TYPE_BLOCKCHAIN' \
--header 'accept: application/json' \
--header 'Authorization: Bearer insXXX' | jq
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 104 100 104 0 0 7888 0 --:--:-- --:--:-- --:--:-- 8000
{
"code": 2,
"message": "check call expr: undeclared identifier 'CONNECTOR_TYPE_BLOCKCHAIN'",
"details": []
} |
fc77cb4
to
371babe
Compare
donch1989
previously approved these changes
Feb 27, 2024
jvallesm
added a commit
to instill-ai/connector
that referenced
this pull request
Feb 27, 2024
Because - We want a wider type / group for non-AI, non-data connectors This commit - renames blockchain connector to Application connector - (compogen) makes source_url fields valid URL - (compogen) fixes property order in REST connector (must start at 0) ## Notes⚠️ `console` and `pipeline-backend` need to take this change into account, otherwise the UI will break. - instill-ai/console#987 - instill-ai/pipeline-backend#397
371babe
to
fa1dd28
Compare
donch1989
pushed a commit
that referenced
this pull request
Feb 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.23.0-beta](v0.22.0-beta...v0.23.0-beta) (2024-02-29) ### Features * rename blockchain connector type to application ([#397](#397)) ([80aa6a5](80aa6a5)) * support reference with `foo["bar"]` syntax ([#394](#394)) ([ed82215](ed82215)) * use `mgmtPB.Owner` to embed the owner information in response ([#392](#392)) ([d071461](d071461)) ### Miscellaneous Chores * release v0.23.0-beta ([53fbd18](53fbd18)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
donch1989
pushed a commit
that referenced
this pull request
Feb 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.23.0-beta](v0.22.0-beta...v0.23.0-beta) (2024-02-29) ### Features * add component definition list endpoint ([#396](#396)) ([b8728c1](b8728c1)) * rename blockchain connector type to application ([#397](#397)) ([80aa6a5](80aa6a5)) * support reference with `foo["bar"]` syntax ([#394](#394)) ([ed82215](ed82215)) * use `mgmtPB.Owner` to embed the owner information in response ([#392](#392)) ([d071461](d071461)) ### Miscellaneous Chores * release v0.23.0-beta ([4d5639b](4d5639b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Mar 1, 2024
donch1989
pushed a commit
that referenced
this pull request
Mar 1, 2024
🤖 I have created a release *beep* *boop* --- ## [0.23.0-beta](v0.22.0-beta...v0.23.0-beta) (2024-03-01) ### Features * add component definition list endpoint ([#396](#396)) ([b8728c1](b8728c1)) * rename blockchain connector type to application ([#397](#397)) ([80aa6a5](80aa6a5)) * support reference with `foo["bar"]` syntax ([#394](#394)) ([ed82215](ed82215)) * use `mgmtPB.Owner` to embed the owner information in response ([#392](#392)) ([d071461](d071461)) ### Bug Fixes * fix component ID with a hyphen cannot be referenced ([#401](#401)) ([1958168](1958168)) ### Miscellaneous Chores * release v0.23.0-beta ([e3ab340](e3ab340)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
connector type and modified the connector and operator list view type.
numbers
connector will become an application connector.This commit
VIEW_XXX
enum values.