Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(run): run logging data list by requester API #730

Merged
merged 4 commits into from
Oct 16, 2024
Merged

feat(run): run logging data list by requester API #730

merged 4 commits into from
Oct 16, 2024

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Oct 12, 2024 •
edited
Loading

Because

  • the data that users could see on dashboard are different from what they can see on Runs page in a single pipeline or model

This commit

  • add new run logging API for dashboard

image

@linear Linear
Copy link

linear bot commented Oct 12, 2024

INS-6567 run logging dashboard list in pipeline

@joremysh joremysh force-pushed the jeremy/ins-6567-run-logging-dashboard-list-in-pipeline branch from 19a7454 to 3f4ab27 Compare October 12, 2024 02:56
@joremysh joremysh marked this pull request as ready for review October 12, 2024 03:17
@joremysh joremysh force-pushed the jeremy/ins-6567-run-logging-dashboard-list-in-pipeline branch 3 times, most recently from 8a8a57f to a4c4f2c Compare October 12, 2024 09:15
@codecov Codecov
Copy link

codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.12766% with 460 lines in your changes missing coverage. Please review.

Project coverage is 19.83%. Comparing base (6a8ce63) to head (a4c4f2c).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
pkg/mock/repository_mock.gen.go 2.96% 325 Missing and 2 partials ⚠️
pkg/service/pipeline.go 0.00% 58 Missing ⚠️
pkg/repository/repository.go 0.00% 46 Missing ⚠️
pkg/handler/pipeline.go 0.00% 28 Missing ⚠️
pkg/service/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
+ Coverage   19.72%   19.83%   +0.11%     
==========================================
  Files         319      320       +1     
  Lines       64013    64784     +771     
==========================================
+ Hits        12625    12851     +226     
- Misses      49488    50015     +527     
- Partials     1900     1918      +18
Flag Coverage Δ
unittests 19.83% <2.12%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jvallesm
jvallesm reviewed Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@jvallesm jvallesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments on this PR, but I see you used another one for the contracts. Still, some of these comments are relevant, so please review them 🙏 . Once we agree on these, the draft PR can be closed.

pkg/handler/pipeline.go Show resolved Hide resolved
pkg/service/component_definition.go Outdated Show resolved Hide resolved
pkg/service/pipeline.go Show resolved Hide resolved
pkg/service/pipeline.go Show resolved Hide resolved
pkg/service/pipeline.go Outdated Show resolved Hide resolved
@joremysh joremysh force-pushed the jeremy/ins-6567-run-logging-dashboard-list-in-pipeline branch 2 times, most recently from b6abdfd to d0ba661 Compare October 16, 2024 03:43
@joremysh joremysh changed the title feat(run): run logging data list by credit owner API feat(run): run logging data list by requester API Oct 16, 2024
@joremysh joremysh force-pushed the jeremy/ins-6567-run-logging-dashboard-list-in-pipeline branch from 829911e to 7ff990d Compare October 16, 2024 05:53
jvallesm
jvallesm reviewed Oct 16, 2024
View reviewed changes
pkg/service/pipeline.go Outdated Show resolved Hide resolved
pkg/service/pipeline.go Outdated Show resolved Hide resolved
pkg/service/pipeline.go Outdated Show resolved Hide resolved
pkg/service/pipeline.go Outdated Show resolved Hide resolved
pkg/repository/repository_test.go Outdated Show resolved Hide resolved
@joremysh joremysh force-pushed the jeremy/ins-6567-run-logging-dashboard-list-in-pipeline branch from 4a0cb8e to 503e48b Compare October 16, 2024 07:34
@joremysh joremysh force-pushed the jeremy/ins-6567-run-logging-dashboard-list-in-pipeline branch from 503e48b to 11bcca7 Compare October 16, 2024 07:43
jvallesm
jvallesm reviewed Oct 16, 2024
View reviewed changes
pkg/service/pipeline.go Outdated Show resolved Hide resolved
@joremysh joremysh merged commit e1e844b into main Oct 16, 2024
11 checks passed
@joremysh joremysh deleted the jeremy/ins-6567-run-logging-dashboard-list-in-pipeline branch October 16, 2024 09:06
@droplet-bot droplet-bot mentioned this pull request Oct 16, 2024
Merged
donch1989 pushed a commit that referenced this pull request Oct 22, 2024
@droplet-bot
chore(main): release 0.44.0-beta (#747)
b496f2a 
🤖 I have created a release *beep* *boop*
---


##
[0.44.0-beta](v0.43.2-beta...v0.44.0-beta)
(2024-10-22)


### Features

* **collection:** add concat
([#748](#748))
([04d1467](04d1467))
* **compogen:** improve Title Case capitalization
([#757](#757))
([f956ead](f956ead))
* **component:** update documentation URL to component ID
([#749](#749))
([d4083c2](d4083c2))
* **instillmodel:** implement instill model embedding
([#727](#727))
([17d88bc](17d88bc))
* **run:** run logging data list by requester API
([#730](#730))
([e1e844b](e1e844b))
* **slack:** enable OAuth 2.0 integration
([#758](#758))
([8043dc5](8043dc5))
* standardize the tag naming convention
([#767](#767))
([fd0500f](fd0500f))
* **web:** refactor web operator
([#753](#753))
([700805f](700805f))


### Bug Fixes

* **groq:** use credential-supported model in example
([#752](#752))
([fc90435](fc90435))
* **run:** not return minio error in list pipeline run
([#744](#744))
([4d0afa1](4d0afa1))
* **whatsapp:** fix dir name
([#763](#763))
([029aef9](029aef9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
jvallesm pushed a commit that referenced this pull request Oct 29, 2024
@droplet-bot @jvallesm
chore(main): release 0.44.0-beta (#747)
802117d 
🤖 I have created a release *beep* *boop*
---


##
[0.44.0-beta](v0.43.2-beta...v0.44.0-beta)
(2024-10-22)


### Features

* **collection:** add concat
([#748](#748))
([04d1467](04d1467))
* **compogen:** improve Title Case capitalization
([#757](#757))
([f956ead](f956ead))
* **component:** update documentation URL to component ID
([#749](#749))
([d4083c2](d4083c2))
* **instillmodel:** implement instill model embedding
([#727](#727))
([17d88bc](17d88bc))
* **run:** run logging data list by requester API
([#730](#730))
([e1e844b](e1e844b))
* **slack:** enable OAuth 2.0 integration
([#758](#758))
([8043dc5](8043dc5))
* standardize the tag naming convention
([#767](#767))
([fd0500f](fd0500f))
* **web:** refactor web operator
([#753](#753))
([700805f](700805f))


### Bug Fixes

* **groq:** use credential-supported model in example
([#752](#752))
([fc90435](fc90435))
* **run:** not return minio error in list pipeline run
([#744](#744))
([4d0afa1](4d0afa1))
* **whatsapp:** fix dir name
([#763](#763))
([029aef9](029aef9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvallesm jvallesm jvallesm approved these changes

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@pinglin pinglin Awaiting requested review from pinglin

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du

Assignees
No one assigned
Labels
instill vdp
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joremysh @jvallesm @droplet-bot