Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(run): not return minio error in list pipeline run #744

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix(run): not return minio error in list pipeline run #744

merged 2 commits into from
Oct 16, 2024

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Oct 16, 2024 •
edited
Loading

Because

  • list pipeline run should return results even if there is an error in minio

This commit

  • log errors instead of return error

@linear Linear
Copy link

linear bot commented Oct 16, 2024

INS-6535 [Bug] Can't View the Run Logging on the Last Page

@joremysh joremysh force-pushed the jeremy/ins-6535-cant-view-the-run-logging-on-the-last-page branch from 5fa3a3e to 15d8783 Compare October 16, 2024 02:44
jvallesm
jvallesm reviewed Oct 16, 2024
View reviewed changes
pkg/service/pipeline.go Outdated Show resolved Hide resolved
pkg/service/utils.go Outdated Show resolved Hide resolved
pkg/service/utils.go Outdated Show resolved Hide resolved
pkg/service/utils.go Outdated Show resolved Hide resolved
@joremysh joremysh merged commit 4d0afa1 into main Oct 16, 2024
11 checks passed
@joremysh joremysh deleted the jeremy/ins-6535-cant-view-the-run-logging-on-the-last-page branch October 16, 2024 07:31
@droplet-bot droplet-bot mentioned this pull request Oct 16, 2024
Merged
donch1989 pushed a commit that referenced this pull request Oct 22, 2024
@droplet-bot
chore(main): release 0.44.0-beta (#747)
b496f2a 
🤖 I have created a release *beep* *boop*
---


##
[0.44.0-beta](v0.43.2-beta...v0.44.0-beta)
(2024-10-22)


### Features

* **collection:** add concat
([#748](#748))
([04d1467](04d1467))
* **compogen:** improve Title Case capitalization
([#757](#757))
([f956ead](f956ead))
* **component:** update documentation URL to component ID
([#749](#749))
([d4083c2](d4083c2))
* **instillmodel:** implement instill model embedding
([#727](#727))
([17d88bc](17d88bc))
* **run:** run logging data list by requester API
([#730](#730))
([e1e844b](e1e844b))
* **slack:** enable OAuth 2.0 integration
([#758](#758))
([8043dc5](8043dc5))
* standardize the tag naming convention
([#767](#767))
([fd0500f](fd0500f))
* **web:** refactor web operator
([#753](#753))
([700805f](700805f))


### Bug Fixes

* **groq:** use credential-supported model in example
([#752](#752))
([fc90435](fc90435))
* **run:** not return minio error in list pipeline run
([#744](#744))
([4d0afa1](4d0afa1))
* **whatsapp:** fix dir name
([#763](#763))
([029aef9](029aef9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
jvallesm pushed a commit that referenced this pull request Oct 29, 2024
@droplet-bot @jvallesm
chore(main): release 0.44.0-beta (#747)
802117d 
🤖 I have created a release *beep* *boop*
---


##
[0.44.0-beta](v0.43.2-beta...v0.44.0-beta)
(2024-10-22)


### Features

* **collection:** add concat
([#748](#748))
([04d1467](04d1467))
* **compogen:** improve Title Case capitalization
([#757](#757))
([f956ead](f956ead))
* **component:** update documentation URL to component ID
([#749](#749))
([d4083c2](d4083c2))
* **instillmodel:** implement instill model embedding
([#727](#727))
([17d88bc](17d88bc))
* **run:** run logging data list by requester API
([#730](#730))
([e1e844b](e1e844b))
* **slack:** enable OAuth 2.0 integration
([#758](#758))
([8043dc5](8043dc5))
* standardize the tag naming convention
([#767](#767))
([fd0500f](fd0500f))
* **web:** refactor web operator
([#753](#753))
([700805f](700805f))


### Bug Fixes

* **groq:** use credential-supported model in example
([#752](#752))
([fc90435](fc90435))
* **run:** not return minio error in list pipeline run
([#744](#744))
([4d0afa1](4d0afa1))
* **whatsapp:** fix dir name
([#763](#763))
([029aef9](029aef9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvallesm jvallesm jvallesm approved these changes

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@pinglin pinglin Awaiting requested review from pinglin

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du

Assignees
No one assigned
Labels
instill vdp
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joremysh @jvallesm @droplet-bot