fix(data): refactor numberData to support both float and integer types #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
==========================================
+ Coverage 20.01% 20.13% +0.11%
==========================================
Files 354 355 +1
Lines 74750 74977 +227
==========================================
+ Hits 14963 15095 +132
- Misses 57571 57655 +84
- Partials 2216 2227 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
donch1989
added a commit
that referenced
this pull request
Nov 12, 2024
#832) Because - Previously, numberData only supported float data, making it difficult to determine whether to stringify it as an original float or integer. This commit - Refactors numberData to support both float and integer types.
donch1989
pushed a commit
that referenced
this pull request
Nov 20, 2024
🤖 I have created a release *beep* *boop* --- ## [0.47.0-beta](v0.46.0-beta...v0.47.0-beta) (2024-11-20) ### Features * **component:** add support for event specifications ([#837](#837)) ([47a61cd](47a61cd)) * **component:** implement run-on-event for Slack and GitHub component ([#842](#842)) ([1b6a569](1b6a569)) * convert pdf to image concurrently ([#818](#818)) ([4c0ad97](4c0ad97)) * improve markdown chunking ([#822](#822)) ([af1a36a](af1a36a)) * **json:** Support Rename Fields for JSON operator ([#813](#813)) ([093714e](093714e)) * **recipe:** refactor run-on-event recipe structure ([#835](#835)) ([78ea418](78ea418)) * **recipe:** rename `instill-format` to `format` ([#798](#798)) ([80a9fc9](80a9fc9)) * **service:** implement PipelineErrorUpdated streaming event for pipeline errors ([#846](#846)) ([3156a5f](3156a5f)) * **vdp:** integrate blob storage to vdp ([#834](#834)) ([5311549](5311549)) * **web:** add input schema to improve web operator ([#819](#819)) ([f7e1fe9](f7e1fe9)) ### Bug Fixes * **data:** refactor numberData to support both float and integer types ([#832](#832)) ([cf27452](cf27452)) * **document:** fix bug about convert to image ([#848](#848)) ([a381c27](a381c27)) * fix bug about unit type ([#826](#826)) ([a89fdf7](a89fdf7)) * **integration-test:** maximize build space on image build & push ([#823](#823)) ([a439d22](a439d22)) * **run:** set pipeline run status as failed when component fails ([#836](#836)) ([70a5c52](70a5c52)) * **service:** add MIME type detection in the backend binaryFetcher ([#854](#854)) ([f434b2b](f434b2b)) * **service:** add missing nil check in includeIteratorComponentDetail() ([#831](#831)) ([9cb5e9e](9cb5e9e)) * **service:** skip empty component definition in API response ([#847](#847)) ([d61b55e](d61b55e)) * unit tests ([#820](#820)) ([717200c](717200c)) * **vdp:** item does not contain the instill format, so we insert it ([#858](#858)) ([2d25401](2d25401)) * **workflow:** allow integration usage within iterator ([#833](#833)) ([c9bd169](c9bd169)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit