Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vdp): item does not contain the instill format, so we insert it #858

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(vdp): item does not contain the instill format, so we insert it #858

merged 1 commit into from
Nov 19, 2024

Conversation

chuang8511
Copy link
Contributor

Because

  • item does not contain instill format

This commit

  • insert instill format into items

@linear Linear
Copy link

linear bot commented Nov 19, 2024

INS-6889 Implementation: Search function, Perplexity AI component

@donch1989 donch1989 merged commit 2d25401 into main Nov 19, 2024
11 checks passed
@donch1989 donch1989 deleted the chunhao/ins-6889-fix-type-bug branch November 19, 2024 16:48
@droplet-bot droplet-bot mentioned this pull request Nov 19, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 20.14%. Comparing base (2d2562c) to head (660d789).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
pkg/service/convert.go 0.00% 13 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
- Coverage   20.19%   20.14%   -0.06%     
==========================================
  Files         362      364       +2     
  Lines       76800    77031     +231     
==========================================
+ Hits        15511    15518       +7     
- Misses      58961    59184     +223     
- Partials     2328     2329       +1
Flag Coverage Δ
unittests 20.14% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

donch1989 pushed a commit that referenced this pull request Nov 20, 2024
@droplet-bot
chore(main): release 0.47.0-beta (#824)
c1d26f8 
🤖 I have created a release *beep* *boop*
---


##
[0.47.0-beta](v0.46.0-beta...v0.47.0-beta)
(2024-11-20)


### Features

* **component:** add support for event specifications
([#837](#837))
([47a61cd](47a61cd))
* **component:** implement run-on-event for Slack and GitHub component
([#842](#842))
([1b6a569](1b6a569))
* convert pdf to image concurrently
([#818](#818))
([4c0ad97](4c0ad97))
* improve markdown chunking
([#822](#822))
([af1a36a](af1a36a))
* **json:** Support Rename Fields for JSON operator
([#813](#813))
([093714e](093714e))
* **recipe:** refactor run-on-event recipe structure
([#835](#835))
([78ea418](78ea418))
* **recipe:** rename `instill-format` to `format`
([#798](#798))
([80a9fc9](80a9fc9))
* **service:** implement PipelineErrorUpdated streaming event for
pipeline errors
([#846](#846))
([3156a5f](3156a5f))
* **vdp:** integrate blob storage to vdp
([#834](#834))
([5311549](5311549))
* **web:** add input schema to improve web operator
([#819](#819))
([f7e1fe9](f7e1fe9))


### Bug Fixes

* **data:** refactor numberData to support both float and integer types
([#832](#832))
([cf27452](cf27452))
* **document:** fix bug about convert to image
([#848](#848))
([a381c27](a381c27))
* fix bug about unit type
([#826](#826))
([a89fdf7](a89fdf7))
* **integration-test:** maximize build space on image build & push
([#823](#823))
([a439d22](a439d22))
* **run:** set pipeline run status as failed when component fails
([#836](#836))
([70a5c52](70a5c52))
* **service:** add MIME type detection in the backend binaryFetcher
([#854](#854))
([f434b2b](f434b2b))
* **service:** add missing nil check in includeIteratorComponentDetail()
([#831](#831))
([9cb5e9e](9cb5e9e))
* **service:** skip empty component definition in API response
([#847](#847))
([d61b55e](d61b55e))
* unit tests
([#820](#820))
([717200c](717200c))
* **vdp:** item does not contain the instill format, so we insert it
([#858](#858))
([2d25401](2d25401))
* **workflow:** allow integration usage within iterator
([#833](#833))
([c9bd169](c9bd169))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@jvallesm jvallesm Awaiting requested review from jvallesm jvallesm is a code owner

Assignees
No one assigned
Labels
instill vdp
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chuang8511 @donch1989 @droplet-bot