Skip to content

Commit

Permalink
Revert "chore(model): update model hardware prop type (#536)"
Browse files Browse the repository at this point in the history
This reverts commit 99c515c.
  • Loading branch information
heiruwu committed Dec 12, 2024
1 parent 99c515c commit 76e87eb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
8 changes: 3 additions & 5 deletions model/model/v1alpha/model.proto
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ message ReadinessResponse {
// Region describes the supported cloud provider and regions, with
// their supported GPU respectively.
message Region {
// Concatenate name of provider and region
// Concate name of provider and region
string region_name = 1;
// Hardware describes the available hardware types in this region
repeated Hardware hardware = 2;
Expand Down Expand Up @@ -200,8 +200,8 @@ message Model {
(google.api.field_behavior) = REQUIRED,
(google.api.field_behavior) = IMMUTABLE
];
// Deleted Fields.
reserved 19;
// Hardware of choice to serve the model.
string hardware = 19 [(google.api.field_behavior) = REQUIRED];
// README holds the model documentation.
optional string readme = 20 [(google.api.field_behavior) = OPTIONAL];
// A link to the source code of the model (e.g. to a GitHub repository).
Expand All @@ -228,8 +228,6 @@ message Model {
repeated string versions = 31 [(google.api.field_behavior) = OUTPUT_ONLY];
// Statistic data.
Stats stats = 32 [(google.api.field_behavior) = OUTPUT_ONLY];
// Hardware of choice to serve the model.
Hardware hardware = 33 [(google.api.field_behavior) = REQUIRED];
}

// ListModelsRequest represents a request to list models.
Expand Down
9 changes: 4 additions & 5 deletions openapi/v2/service.swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8990,6 +8990,9 @@ definitions:
region:
type: string
description: Region of choice for the particular provider to host the model.
hardware:
type: string
description: Hardware of choice to serve the model.
readme:
type: string
description: README holds the model documentation.
Expand Down Expand Up @@ -9035,10 +9038,6 @@ definitions:
readOnly: true
allOf:
- $ref: '#/definitions/Model.Stats'
hardware:
description: Hardware of choice to serve the model.
allOf:
- $ref: '#/definitions/Hardware'
title: |-
Model represents an AI model, i.e. a program that performs tasks as decision
making or or pattern recognition based on its training data
Expand Down Expand Up @@ -9986,7 +9985,7 @@ definitions:
properties:
regionName:
type: string
title: Concatenate name of provider and region
title: Concate name of provider and region
hardware:
type: array
items:
Expand Down

0 comments on commit 76e87eb

Please sign in to comment.