Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(model): update model hardware prop type #536

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Dec 12, 2024

Because

  • unify hardware prop type

This commit

  • update model hardware prop type

Copy link

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 12, 2024, 6:41 AM

@heiruwu heiruwu merged commit 99c515c into main Dec 12, 2024
@heiruwu heiruwu deleted the update-missing-hardware-prop branch December 12, 2024 06:41
heiruwu added a commit that referenced this pull request Dec 12, 2024
heiruwu added a commit that referenced this pull request Dec 12, 2024
heiruwu added a commit that referenced this pull request Dec 12, 2024
…536)" (#537)

Because

- hardware should stay as string

This commit

- reverts commit 99c515c.

---------

Co-authored-by: droplet-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants