Update Python 3.12 #304
Update Python 3.12 #304
Conversation
Now that PyTorch 2.4 supports Python 3.12, This change attempts updating the default Python version to 3.12, jointly with the other repositories of the instructlab project. Signed-off-by: Fabien Dupont <[email protected]>
mergify
bot
added
CI/CD
|
Looks like instructlab/instructlab#2434 was closed in favor of instructlab/instructlab#2445, but it doesn't appear that the latter updated Python. Is this still relevant @fabiendupont ? |
|
It would be great for SDG to work with Python 3.12 (or newer), but I'm not sure the best way to do that without moving everything over to Python 3.12. We need to remain compatible with Python 3.11 to work with the rest of InstructLab until or unless it moves to Python 3.12, so I don't think we'd want to merge this as-is and bump most of our testing to Python 3.12. Perhaps we need some kind of scheduled jobs that run all of our automated tests with each Python version so that we have confidence in the Python versions we can support? |
|
I'm closing this one in favor of a slimmed down version opened in #524 - that newer PR only adds Python 3.12 to our unit and functional test matrix, which will allow us to ensure SDG works with Python 3.12. It still runs the |
|
Oh, and because I started from this PR as a base, I retained co-authorship over in #524. Thanks for the contribution! |
Now that PyTorch 2.4 supports Python 3.12, This change attempts updating the default Python version to 3.12, jointly with the other repositories of the instructlab project.