Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to our unit and functional tests #524

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

bbrowning
Copy link
Contributor

To prepare SDG for supporting Python 3.12, this adds Python 3.12 to our unit and functional testing matrix alongside our Python 3.11 and 3.10 tests.

This is NOT running the ilab end-to-end workflow with Python 3.12, as InstructLab does not yet support Python 3.11.

To prepare SDG for supporting Python 3.12, this adds Python 3.12 to our
unit and functional testing matrix alongside our Python 3.11 and 3.10
tests.

This is NOT running the `ilab` end-to-end workflow with Python 3.12, as
InstructLab does not yet support Python 3.11.

Co-authored-by: Fabien Dupont <[email protected]>
Signed-off-by: Ben Browning <[email protected]>
@mergify mergify bot added CI/CD Affects CI/CD configuration testing Relates to testing labels Jan 29, 2025
@bbrowning bbrowning mentioned this pull request Jan 29, 2025
@bbrowning bbrowning requested a review from a team January 29, 2025 16:05
@mergify mergify bot added the one-approval label Jan 29, 2025
@bbrowning bbrowning merged commit 9f68566 into instructlab:main Jan 29, 2025
17 checks passed
@bbrowning bbrowning deleted the 1463-update-python-3.12 branch January 29, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Affects CI/CD configuration one-approval testing Relates to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants