feat: use runtime in the example app #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanregisser
force-pushed
the
jeanregisser/example-with-runtime
branch
from
5c536ef to
aeb54b8
Compare
jeanregisser
force-pushed
the
jeanregisser/example-with-runtime
branch
from
aeb54b8 to
94d6c89
Compare
bakoushin
reviewed
Jan 9, 2025
packages/runtime/package.json
Outdated
| @@ -53,6 +53,7 @@ | |||
| "generate-release-notes": "ts-node ./scripts/generate-release-notes.ts", | |||
| "deploy:update-disclaimer": "yarn licenses generate-disclaimer --prod > src/account/LicenseDisclaimer.txt && ./scripts/copy_license_to_android_assets.sh", | |||
| "//postinstall": "patch-package && yarn keys:decrypt && ./scripts/copy_license_to_android_assets.sh", | |||
| "postinstall": "cp secrets.json.template secrets.json", | |||
There was a problem hiding this comment.
this will overwrite secrets.json every time someone runs yarn install, for instance, to install new dependencies updated in the repo. is that okay?
There was a problem hiding this comment.
Yes because secrets will be handled by end apps.
This is just a stop gap solution to fix compilation in the runtime which currently imports that file.
bakoushin
reviewed
Jan 9, 2025
|
|
||
| const SEARCH_STRING = 'defaultConfig {' | ||
|
|
||
| // Temporary plugin to fix the camera build issue on Android |
There was a problem hiding this comment.
I wonder if we can switch to expo-camera in the future
jeanregisser
added a commit
that referenced
this pull request
Jan 10, 2025
…#4) ### Description This PR introduces an example app using Expo, generated with the following command: ```bash npx create-expo-app@latest --template blank-typescript apps/example ``` While setting up this app, compatibility issues arose between Expo's use of `[email protected]` and our runtime's use of `[email protected]`. These were resolved by: 1. **Moving the runtime's native dependencies to `peerDependencies`**: - This follows best practices for libraries that have native deps, enabling auto-linking in the final app. - Reference: [react-native-community/cli#870](react-native-community/cli#870) (still unresolved but relevant). 2. **Adding root resolutions**: - Ensures only one version of `react-native` and related dependencies is used. Additionally, changes were made to the runtime tests due to differences in how the `<Modal />` component renders in tests with the new `react-native` version. Specifically, `<Modal />` now renders as `null` when not visible. Note: the example app doesn't yet consume the runtime, see #6 for that. Part of RET-1279
jeanregisser
force-pushed
the
jeanregisser/example-with-runtime
branch
from
d03a3ab to
a7b94cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the example app to use the runtime.
Similar to what was done in the prototype: https://github.com/mobilestack-xyz/app-expo
Except I've left out firebase for now.
The app now builds and runs on iOS and Android.
Though there's a crash in the setting due to Statsig not being configured. This is being addressed in valora-inc#6403.
Next: make e2e tests work with the example app.
Part of RET-1279