[uss_qualifier] acces proper activity result field in down_uss.py #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read the correct field when running the check for the planned activity's result
Shastick
force-pushed
the
down-uss-result-fix
branch
from
416d50e to
1b61242
Compare
github-actions bot
added a commit
that referenced
this pull request
Jul 15, 2024
Read the correct field when running the check for the planned activity's result e82cbf6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the correct field when running the check for the planned activity's result.
(The only field with result in its name is
activity_resultand using that field seems to fix the original purpose of the code).This should fix #730
Now, I'm unsure why we did not catch this via the CI runs:
DownUSSis configured to run as part of thef3548_21.yamlsuite which is included in multiple scenario configurations.I assume we're not covering a particular corner case, but I won't look into this further until we have a quick chat about it in the next weekly meeting.