RGBD odometry: separate rgb_transport and depth_transport params #1282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's just a single image transport parameter, which practically cannot be set to anything other than
raw
, since depth cannot be transported usingcompressed
and color can't usecompressedDepth
either.This PR separates the
image_transport
parameter into two,rgb_transport
anddepth_transport
, which will allow for compressed input.Note: There's also an unrelated change that introduces the call to
resolve_topic_or_service_name
prior to subscribing, which helped with subscribing to remapped topics in a namespace IIRC.