Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGBD odometry: separate rgb_transport and depth_transport params #1282

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from

Conversation

rayferric
Copy link

Currently, there's just a single image transport parameter, which practically cannot be set to anything other than raw, since depth cannot be transported using compressed and color can't use compressedDepth either.

This PR separates the image_transport parameter into two, rgb_transport and depth_transport, which will allow for compressed input.

Note: There's also an unrelated change that introduces the call to resolve_topic_or_service_name prior to subscribing, which helped with subscribing to remapped topics in a namespace IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant