Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alert): input validation #12541

Closed
wants to merge 118 commits into from
Closed

feat(alert): input validation #12541

wants to merge 118 commits into from

Conversation

dudeofawesome
Copy link
Contributor

@dudeofawesome dudeofawesome commented Aug 1, 2017 •
edited
Loading

Short description of what this resolves:

Add user-friendly input validation for Alert dialogs.

Changes proposed in this pull request:

  • Add ability to do Angular form validation inside Alerts.
  • Add 'submit' role to AlertButton. This allows for disabling form submission when the form is invalid.
  • Converts Alert form to a Reactive Form.
  • Improve type definition for AlertOptions.
  • Use @HostBinding decorator, per Angular Style Guide.
  • Fix a few typos in already existing alert documentation.

Ionic Version: 3.x

Fixes: #12540 #7819 #5916

dudeofawesome and others added 30 commits November 27, 2016 23:52
@dudeofawesome
Merge remote-tracking branch 'driftyco/master'
47d2f14
@brandyscarney
style(util): remove commented out test css
a91a68e
@Manduro @manucorporat
fix(refresher): border should only show when pulled (ionic-team#12015)
47e3c70 
fixes ionic-team#10994
@manucorporat
fix(keyboard): big keyboard/input refactor
c10f72b 
fixes ionic-team#9699
fixes ionic-team#11484
fixes ionic-team#11389
fixes ionic-team#11325
fixes ionic-team#11291
fixes ionic-team#10828
fixes ionic-team#11291
fixes ionic-team#10393
fixes ionic-team#10257
fixes ionic-team#9434
fixes ionic-team#8933
fixes ionic-team#7178
fixes ionic-team#7047
fixes ionic-team#10552
fixes ionic-team#10393
fixes ionic-team#10183
fixes ionic-team#10187
fixes ionic-team#10852
fixes ionic-team#11578
@manucorporat
Merge branch 'keyboard-fixes'
6dee17b
@manucorporat
fix(input): add correct translate3d for rtl
ef85ba6 
thanks @Khalid-Nowaf

fixes ionic-team#11745
fixes ionic-team#11211
@Manduro @manucorporat
fix(input): use all supported attributes on both textareas and inputs (…
8041eed 
…ionic-team#12028)
@manucorporat
fix(input): better handling of attributes
9f86e10
@manucorporat
fix(textarea): apply classes properly
dc958c3
@Manduro @manucorporat
fix(input): slightly longer delay for autofocus (ionic-team#12037)
54ac2e3
@danbucholtz
chore(changelog): 3.4.0 release
2791c40
@danbucholtz
chore(dependencies): update package version to 3.4.0
f149c5e
@danbucholtz
chore(github): update issue template plunkr to 3.4.0 version
3564bcf
@manucorporat
fix(input): prevent duplicated tabIndex (ionic-team#12043)
7a1342c 
fixes ionic-team#7178
@manucorporat
refactor(overlay): simplify focusOutActiveElement (ionic-team#12023)
2743c63
@zakton5 @manucorporat
feat(select): add compareWith Input for object value comparison (ioni…
c7645ee 
…c-team#11965)

fixes ionic-team#6625
@manucorporat
fix(highlight): selected tab might be null
5a5da39 
fixes ionic-team#12054
@danbucholtz
chore(changelog): add upgrade instructions for 3.4.0
1a4aacf
@manucorporat
fix(sliding-item): super slow device does get correct classes
6193560 
fixes ionic-team#11988
@AmitMY @manucorporat
feat(item-reorder): add side support (ionic-team#11642)
63f728f 
fixes ionic-team#11637
@manucorporat
perf(item): button-effect is hidden for non buttons
8bd2f24
@manucorporat
style(reorder): using const
7803998
@dudeofawesome @manucorporat
fix(tabs): properly align tabs highlight (ionic-team#11619)
a8731df 
When `Tabs` are nested within each other, the highlight can get
misaligned. This prevents that by ensuring the affected
`.tab-highlight` is a direct child of the targeted `Tabs`.
@danbucholtz
chore(changelog): fix typo, update deps to latest
877d821
@brandyscarney
fix(themes): change default app-direction
1ca7df7
@brandyscarney
chore(ionic): release 3.4.1
5094fee
@brandyscarney
fix(rtl): use multi direction in order to override the default ltr
70b5b6b
@brandyscarney
chore(ionic): release 3.4.2
d8b65da
@manucorporat
fix(select): floating label
e3a8d27 
fixes ionic-team#12068
@danbucholtz
feature(navigation): modify urls to support multiple root level navs/…
5cad965 
…tabs

* wip

* wip

* progress

* wippy skippy

* getting there

* all tests passing except goBack

* unit tests pass again boi

* goBack tests pass

* great success

* the good stuff
@dudeofawesome
docs(alert): jsdoc for AlertOptions
71555f2
@dudeofawesome
refactor(alert): convert to HostBinding decorator
d13b8ba 
This is by [recommendation from the Angular Style
Guide](https://angular.io/guide/styleguide#hostlistenerhostbinding-decor
 ators-versus-host-metadata)
@dudeofawesome
refactor(alert): use template literal for template string
98fb018 
This allows the Angular TypeScript Language Service to tell editors how
to highlight and lint the template properly, as well as making editing
and reading the template much simpler.
@dudeofawesome
feat(alert): add validators options to AlertOptions
52e97b4
@dudeofawesome
feat(alert): convert to reactive form, enable validation
faab818
@dudeofawesome
feat(alert): improve AlertOptions definition
4080383
@dudeofawesome
feat(alert): create submit button role
e276bb4
@dudeofawesome
feat(alert): color invalid inputs
ad21c5d
@dudeofawesome
feat(alert): show validation error messages
8a43cc5
@dudeofawesome
feat(alert): improve error message styling
34649dd
@dudeofawesome
fix(alert): built-in min and max validators act as expected
89807c0 
They now set min and max values, instead of min and max lengths.
@dudeofawesome
style(alert): fix lint errors
6eb0aee
@dudeofawesome
style(alert): fix lint errors
d290083
@dudeofawesome
docs(alert): add validation to example
6d82827
@dudeofawesome
style(alert): rename injected FormBuilder
2e112c8
@dudeofawesome
docs(alert): update input options docs
1a532b6
@dudeofawesome
fix(alert): return input values
b1e59a3
@dudeofawesome
feat(alert): improve validation error on iOS
afe4d62
@dudeofawesome
fix(alert): allowing string min and max for date inputs
010e19d
@dudeofawesome
test(alert): input valid values
e121fd9
@dudeofawesome
fix(alert): allow input values to be numbers
8222759
@dudeofawesome
test(alert): WIP add karma test
63e125f
@dudeofawesome
feat(alert): only show errors for dirty inputs
ae128cd
@dudeofawesome
feat(alert): only show errors for dirty inputs
f5dc712
@Ionitron
Copy link
Collaborator

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!

@Ionitron Ionitron closed this Mar 12, 2018
@Farbdose Farbdose mentioned this pull request Aug 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.