Code

feat(alert): input validation#12541

Code

Closed

dudeofawesome wants to merge 118 commits intoionic-team:masterionic-team/ionic-framework:masterfrom dudeofawesome:feature/alert-input-validationdudeofawesome/ionic:feature/alert-input-validationCopy head branch name to clipboard

+23,514-2,911

Commits

Commits on Nov 28, 2016

• Merge remote-tracking branch 'driftyco/master'

  dudeofawesome

  committed
  47d2f14

  Copy full SHA for 47d2f14

Commits on Jun 12, 2017

• style(util): remove commented out test css

  brandyscarney

  authored
  a91a68e

  Copy full SHA for a91a68e

• fix(refresher): border should only show when pulled (ionic-team#12015)

  Show description for 47e3c70
  

  Manduro

  authored and

  manucorporat

  committed
  47e3c70

  Copy full SHA for 47e3c70

• fix(keyboard): big keyboard/input refactor

  Show description for c10f72b
  manucorporat

  committed
  c10f72b

  Copy full SHA for c10f72b

• Merge branch 'keyboard-fixes'

  manucorporat

  committed
  6dee17b

  Copy full SHA for 6dee17b

• fix(input): add correct translate3d for rtl

  Show description for ef85ba6
  manucorporat

  committed
  ef85ba6

  Copy full SHA for ef85ba6

Commits on Jun 13, 2017

• fix(input): use all supported attributes on both textareas and inputs (ionic-team#12028)

  

  Manduro

  authored and

  manucorporat

  committed
  8041eed

  Copy full SHA for 8041eed

• fix(input): better handling of attributes

  manucorporat

  committed
  9f86e10

  Copy full SHA for 9f86e10

• fix(textarea): apply classes properly

  manucorporat

  committed
  dc958c3

  Copy full SHA for dc958c3

Commits on Jun 14, 2017

• fix(input): slightly longer delay for autofocus (ionic-team#12037)

  

  Manduro

  authored and

  manucorporat

  committed
  54ac2e3

  Copy full SHA for 54ac2e3

Commits on Jun 15, 2017

• chore(changelog): 3.4.0 release

  danbucholtz

  committed
  2791c40

  Copy full SHA for 2791c40

• chore(dependencies): update package version to 3.4.0

  danbucholtz

  committed
  f149c5e

  Copy full SHA for f149c5e

• chore(github): update issue template plunkr to 3.4.0 version

  danbucholtz

  committed
  3564bcf

  Copy full SHA for 3564bcf

• fix(input): prevent duplicated tabIndex (ionic-team#12043)

  Show description for 7a1342c
  manucorporat

  authored
  7a1342c

  Copy full SHA for 7a1342c

• refactor(overlay): simplify focusOutActiveElement (ionic-team#12023)

  manucorporat

  authored
  2743c63

  Copy full SHA for 2743c63

• feat(select): add compareWith Input for object value comparison (ionic-team#11965)

  Show description for c7645ee
  

  zakton5

  authored and

  manucorporat

  committed
  c7645ee

  Copy full SHA for c7645ee

• fix(highlight): selected tab might be null

  Show description for 5a5da39
  manucorporat

  committed
  5a5da39

  Copy full SHA for 5a5da39

• chore(changelog): add upgrade instructions for 3.4.0

  danbucholtz

  committed
  1a4aacf

  Copy full SHA for 1a4aacf

• fix(sliding-item): super slow device does get correct classes

  Show description for 6193560
  manucorporat

  committed
  6193560

  Copy full SHA for 6193560

• feat(item-reorder): add side support (ionic-team#11642)

  Show description for 63f728f
  

  AmitMY

  authored and

  manucorporat

  committed
  63f728f

  Copy full SHA for 63f728f

• perf(item): button-effect is hidden for non buttons

  manucorporat

  committed
  8bd2f24

  Copy full SHA for 8bd2f24

• style(reorder): using const

  manucorporat

  committed
  7803998

  Copy full SHA for 7803998

• fix(tabs): properly align tabs highlight (ionic-team#11619)

  Show description for a8731df
  

  dudeofawesome

  authored and

  manucorporat

  committed
  a8731df

  Copy full SHA for a8731df

Commits on Jun 16, 2017

• chore(changelog): fix typo, update deps to latest

  danbucholtz

  authored
  877d821

  Copy full SHA for 877d821

• fix(themes): change default app-direction

  brandyscarney

  committed
  1ca7df7

  Copy full SHA for 1ca7df7

• chore(ionic): release 3.4.1

  brandyscarney

  committed
  5094fee

  Copy full SHA for 5094fee

• fix(rtl): use multi direction in order to override the default ltr

  brandyscarney

  committed
  70b5b6b

  Copy full SHA for 70b5b6b

• chore(ionic): release 3.4.2

  brandyscarney

  committed
  d8b65da

  Copy full SHA for d8b65da

Commits on Jun 19, 2017

• fix(select): floating label

  Show description for e3a8d27
  manucorporat

  committed
  e3a8d27

  Copy full SHA for e3a8d27

• feature(navigation): modify urls to support multiple root level navs/tabs

  Show description for 5cad965
  danbucholtz

  authored
  5cad965

  Copy full SHA for 5cad965

• chore(build): strictly enforce metadata

  danbucholtz

  committed
  00fbded

  Copy full SHA for 00fbded

• chore(build): fix path issue in snapshot test

  danbucholtz

  committed
  bcc85d9

  Copy full SHA for bcc85d9

Commits on Jun 20, 2017

• docs(changelog): fix broken commit links

  brandyscarney

  authored
  6f7acdb

  Copy full SHA for 6f7acdb

• fix(navigation): add isTab check to getSegmentsFromNav

  danbucholtz

  committed
  f39c381

  Copy full SHA for f39c381

• chore(nav): fix lint errors in test

  danbucholtz

  committed
  0480f73

  Copy full SHA for 0480f73

• refactor(app): refactor app slightly to maintain backwards compatibility

  danbucholtz

  committed
  58e1d79

  Copy full SHA for 58e1d79

• refactor(navigation): refactor nav-controller-base to maintain backwards compatibility

  danbucholtz

  committed
  1beef75

  Copy full SHA for 1beef75

• fix(navigation): fallback to name if component does not exist on segment

  danbucholtz

  committed
  30f69c8

  Copy full SHA for 30f69c8

• add href for additional testing

  danbucholtz

  committed
  fba6ff0

  Copy full SHA for fba6ff0

Commits on Jun 23, 2017

• docs(api): angularjs to angular

  Show description for 86495e1
  

  janpio

  authored and

  mhartington

  committed
  86495e1

  Copy full SHA for 86495e1

Commits on Jun 27, 2017

• feature(navigation): better browser back/forward button support

  Show description for 0f5c47d
  danbucholtz

  authored
  0f5c47d

  Copy full SHA for 0f5c47d

• fix(tabs): use segment if it exists even if component exists

  danbucholtz

  committed
  016b90d

  Copy full SHA for 016b90d

Commits on Jun 28, 2017

• docs(menu): fix link to menucontroller

  mhartington

  committed
  bc7bb21

  Copy full SHA for bc7bb21

• fix(select): _inputUpdated should not be called manually

  manucorporat

  committed
  8dc08f9

  Copy full SHA for 8dc08f9

• chore(changelog): 3.5.0 changelog

  danbucholtz

  committed
  a92d805

  Copy full SHA for a92d805

• chore(changelog): additional nav change details

  Show description for 048af1b
  danbucholtz

  committed
  048af1b

  Copy full SHA for 048af1b

• chore(dependencies): update app-scripts to 1.3.11, add npm 5 support

  Show description for 5771543
  danbucholtz

  committed
  5771543

  Copy full SHA for 5771543

• chore(dependencies): lock file updated

  danbucholtz

  committed
  a7e5fa7

  Copy full SHA for a7e5fa7

Commits on Jun 29, 2017

• feat(navigation): support for named ion-nav/ion-tabs to improve url in the short term

  Show description for 486bff0
  danbucholtz

  committed
  486bff0

  Copy full SHA for 486bff0

• fix(navigation): mark as not transitioning on success in addition to '_transitionFinish', provide no

  Show description for 48b3243
  danbucholtz

  committed
  48b3243

  Copy full SHA for 48b3243

Commits on Jun 30, 2017

• fix(navigation): fix swipe-to-go-back

  Show description for 04e78d8
  danbucholtz

  committed
  04e78d8

  Copy full SHA for 04e78d8

• fix(navigation): navs can have n child navs instead of just one

  danbucholtz

  committed
  fce4422

  Copy full SHA for fce4422

Commits on Jul 3, 2017

• fix(tabs): have tabs behavior match nav when navigating back/forth via the url

  danbucholtz

  committed
  3f39e14

  Copy full SHA for 3f39e14

• chore(app): fix linting issues

  Show description for eb830d4
  danbucholtz

  committed
  eb830d4

  Copy full SHA for eb830d4

Commits on Jul 5, 2017

• chore(lint): fix all code that doesn't pass tslint

  Show description for efd5475
  danbucholtz

  authored
  efd5475

  Copy full SHA for efd5475

Commits on Jul 6, 2017

• fix(navigation): restore getActiveChildNav method to maintain old API, add deprecation notice

  danbucholtz

  committed
  d22d77b

  Copy full SHA for d22d77b

• chore(build): remove linting checks we do not want for dist

  jgw96

  committed
  5a4b351

  Copy full SHA for 5a4b351

• chore(build): use cross-spawn instead of spawn

  jgw96

  committed
  e079f77

  Copy full SHA for e079f77

• chore(build): import spawnSync from correct package

  jgw96

  committed
  923e3b2

  Copy full SHA for 923e3b2

• chore(lockfile): idk why this thing keeps updating

  danbucholtz

  committed
  3e3a00b

  Copy full SHA for 3e3a00b

Commits on Jul 10, 2017

• fix(sliding-item): ionSwipe event is fired (ionic-team#12157)

  Show description for b5aa304
  manucorporat

  authored
  b5aa304

  Copy full SHA for b5aa304

• docs(content): type Sroll => Scroll (ionic-team#12281)

  

  janpio

  authored and

  manucorporat

  committed
  693c1c5

  Copy full SHA for 693c1c5

• fix(select): not activated on enter in input field

  Show description for ad25cd1
  manucorporat

  committed
  ad25cd1

  Copy full SHA for ad25cd1

• fix(navigation): ts2.4 compatibility

  Show description for 08be9dc
  

  RoopeHakulinen

  authored and

  mhartington

  committed
  08be9dc

  Copy full SHA for 08be9dc

Commits on Jul 12, 2017

• chore(dependencies): recreate lockfile with npm 5.1

  danbucholtz

  committed
  9ffc52b

  Copy full SHA for 9ffc52b

Commits on Jul 13, 2017

• docs(events): fix syntax error (ionic-team#12317)

  Show description for 347c260
  

  pranjal-goswami

  authored and

  brandyscarney

  committed
  347c260

  Copy full SHA for 347c260

• chore(generator): remove ionicPage for now (ionic-team#12347)

  

  mhartington

  authored and

  danbucholtz

  committed
  6d8da0a

  Copy full SHA for 6d8da0a

• chore(changelog): update to 3.5.1

  Show description for 2153940
  danbucholtz

  committed
  2153940

  Copy full SHA for 2153940

• chore(changelog): 3.5.2 release

  Show description for acb6fac
  danbucholtz

  committed
  acb6fac

  Copy full SHA for acb6fac

• chore(changelog): 3.5.2 upgrade instructions

  danbucholtz

  committed
  889b49f

  Copy full SHA for 889b49f

• chore(changelog): additional details about upgrading and updating app-scripts

  danbucholtz

  committed
  4c13535

  Copy full SHA for 4c13535

• docs(toast): add import statement in usage (ionic-team#12278)

  Show description for d23b9f7
  

  b264

  authored and

  brandyscarney

  committed
  d23b9f7

  Copy full SHA for d23b9f7

Commits on Jul 14, 2017

• chore(changelog): update changelog to save app-scripts as devDependency

  

  peterpeterparker

  authored and

  danbucholtz

  committed
  f7fce5f

  Copy full SHA for f7fce5f

• chore(changelog): 3.5.2 changelog

  Show description for ce46c24
  danbucholtz

  committed
  ce46c24

  Copy full SHA for ce46c24

• fix(app): restore getActiveNav api

  Show description for 2d49e10
  danbucholtz

  committed
  2d49e10

  Copy full SHA for 2d49e10

• chore(dependencies): add angular/tsc-wrapper to package.json to avoid npm issues people are having

  danbucholtz

  committed
  ab511c4

  Copy full SHA for ab511c4

• chore(dependencies): removing tsc-wrapped since angular explicitely says not to do this

  danbucholtz

  committed
  cec718c

  Copy full SHA for cec718c

• chore(dependencies): update the lock file

  danbucholtz

  committed
  c4e7552

  Copy full SHA for c4e7552

• chore(changelog): 3.5.3 release

  danbucholtz

  committed
  5b9fe5e

  Copy full SHA for 5b9fe5e

Commits on Jul 18, 2017

• chore(docs): add anchor links to documentation sub-sections (ionic-team#12386)

  Show description for 961bfc3
  

  samuelgoodell

  authored and

  perrygovier

  committed
  961bfc3

  Copy full SHA for 961bfc3

Commits on Jul 21, 2017

• fix(list): remove margin of MD buttons in ion-item-options (ionic-team#12263)

  

  pwespi

  authored and

  brandyscarney

  committed
  97f9522

  Copy full SHA for 97f9522

Commits on Jul 22, 2017

• fix(navigation): reduce urls to minimum set of fields

  Show description for a8ceee4
  danbucholtz

  authored
  a8ceee4

  Copy full SHA for a8ceee4

Commits on Jul 24, 2017

• chore(karma): fix duplicate console.log issue

  danbucholtz

  committed
  519d657

  Copy full SHA for 519d657

• fix(navigation): fix bug where that occurred when tab identifier and segment had the exact same string

  danbucholtz

  committed
  add0c4e

  Copy full SHA for add0c4e

Commits on Jul 25, 2017

• feat(generators): refactor generators

  Show description for 400aa54
  mhartington

  authored
  400aa54

  Copy full SHA for 400aa54

• fix(navigation): account for race conditions in developer's code

  danbucholtz

  committed
  4596dbe

  Copy full SHA for 4596dbe

Commits on Jul 26, 2017

• fix(nav): make call to setPages return the promise so if it rejects it doesn't get lost

  danbucholtz

  committed
  de0f9d5

  Copy full SHA for de0f9d5

• fix(navigation): fix null pointer exceptions that would occur when destroying a nav controller while its transitioning

  danbucholtz

  committed
  584afd0

  Copy full SHA for 584afd0

Commits on Jul 27, 2017

• chore(changelog): 3.6.0 changelog

  danbucholtz

  committed
  16f2ebe

  Copy full SHA for 16f2ebe

• chore(changelog): change --save to --save-dev for app-scripts

  danbucholtz

  authored
  e401997

  Copy full SHA for e401997

• chore(changelog): add details about tabUrlPath to changelog

  danbucholtz

  authored
  f605f0a

  Copy full SHA for f605f0a

Commits on Aug 1, 2017

• Merge remote-tracking branch 'ionic-team/master'

  dudeofawesome

  committed
  fe8e049

  Copy full SHA for fe8e049

• style(alert): fix linter errors

  dudeofawesome

  committed
  44444c3

  Copy full SHA for 44444c3

• docs(alert): fix typos

  dudeofawesome

  committed
  c84cc6c

  Copy full SHA for c84cc6c

• docs(alert): jsdoc for AlertOptions

  dudeofawesome

  committed
  71555f2

  Copy full SHA for 71555f2

• refactor(alert): convert to HostBinding decorator

  Show description for d13b8ba
  dudeofawesome

  committed
  d13b8ba

  Copy full SHA for d13b8ba

• refactor(alert): use template literal for template string

  Show description for 98fb018
  dudeofawesome

  committed
  98fb018

  Copy full SHA for 98fb018

• feat(alert): add validators options to AlertOptions

  dudeofawesome

  committed
  52e97b4

  Copy full SHA for 52e97b4

• feat(alert): convert to reactive form, enable validation

  dudeofawesome

  committed
  faab818

  Copy full SHA for faab818

• feat(alert): improve AlertOptions definition

  dudeofawesome

  committed
  4080383

  Copy full SHA for 4080383

• feat(alert): create submit button role

  dudeofawesome

  committed
  e276bb4

  Copy full SHA for e276bb4

• feat(alert): color invalid inputs

  dudeofawesome

  committed
  ad21c5d

  Copy full SHA for ad21c5d

• feat(alert): show validation error messages

  dudeofawesome

  committed
  8a43cc5

  Copy full SHA for 8a43cc5

• feat(alert): improve error message styling

  dudeofawesome

  committed
  34649dd

  Copy full SHA for 34649dd

• fix(alert): built-in min and max validators act as expected

  Show description for 89807c0
  dudeofawesome

  committed
  89807c0

  Copy full SHA for 89807c0

• style(alert): fix lint errors

  dudeofawesome

  committed
  6eb0aee

  Copy full SHA for 6eb0aee

• style(alert): fix lint errors

  dudeofawesome

  committed
  d290083

  Copy full SHA for d290083

• docs(alert): add validation to example

  dudeofawesome

  committed
  6d82827

  Copy full SHA for 6d82827

• style(alert): rename injected FormBuilder

  dudeofawesome

  committed
  2e112c8

  Copy full SHA for 2e112c8

• docs(alert): update input options docs

  dudeofawesome

  committed
  1a532b6

  Copy full SHA for 1a532b6

Commits on Aug 2, 2017

• fix(alert): return input values

  dudeofawesome

  committed
  b1e59a3

  Copy full SHA for b1e59a3

Commits on Aug 5, 2017

• feat(alert): improve validation error on iOS

  dudeofawesome

  committed
  afe4d62

  Copy full SHA for afe4d62

• fix(alert): allowing string min and max for date inputs

  dudeofawesome

  committed
  010e19d

  Copy full SHA for 010e19d

• test(alert): input valid values

  dudeofawesome

  committed
  e121fd9

  Copy full SHA for e121fd9

• fix(alert): allow input values to be numbers

  dudeofawesome

  committed
  8222759

  Copy full SHA for 8222759

• test(alert): WIP add karma test

  dudeofawesome

  committed
  63e125f

  Copy full SHA for 63e125f

Commits on Aug 16, 2017

• feat(alert): only show errors for dirty inputs

  dudeofawesome

  committed
  ae128cd

  Copy full SHA for ae128cd

• feat(alert): only show errors for dirty inputs

  dudeofawesome

  committed
  f5dc712

  Copy full SHA for f5dc712