feat(toggle): add helperText and errorText properties #30161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
thetaPC
requested changes
Jan 31, 2025
| @@ -337,6 +396,7 @@ export class Toggle implements ComponentInterface { | |||
| part="label" | |||
| > | |||
| <slot></slot> | |||
| {this.renderHintText()} | |||
There was a problem hiding this comment.
The text (helper or error) is being read twice by VoiceOver on Safari, Firefox, and Chrome. After some quick debugging, it seems that this happening because the text is inside of label. ion-input has it after the which mimics how the native input states it.
Screen.Recording.2025-01-30.at.4.30.15.PM.mov
| configs({ modes: ['ios', 'md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { | ||
| test.describe(title('toggle: helper text rendering'), () => { | ||
| // Check the default label placement, end, and stacked | ||
| [undefined, 'end', 'stacked'].forEach((labelPlacement) => { |
There was a problem hiding this comment.
What was the reasoning for not checking fixed?
| }); | ||
| }); | ||
|
|
||
| test.describe(title('toggle: error text rendering'), () => { |
There was a problem hiding this comment.
Why does error text not get a check for the end or fixed placement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Toggle does not support helper and error text.
What is the new behavior?
Adds support for helper and error text, similar to input and textarea.
Does this introduce a breaking change?
Other information